Skip to content

Commit c2f3d76

Browse files
committed
[libc++] Remove labels from CSV status pages
We used to provide associate labels to individual rows in the status tracking CSV files. This was useful to find issues related to a specific part of the library. However, since we now have Github to track this information, using labels in the CSV files is not really useful. Furthermore, keeping the labels synchronized between the CSV files and the ever-changing Github issues is going to be very challenging.
1 parent 84fa7b4 commit c2f3d76

10 files changed

+1527
-1565
lines changed

libcxx/docs/Helpers/Styles.rst

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,6 @@
1717
font-style: italic;
1818
}
1919
.complete { background-color: #99FF99; }
20-
.chrono { background-color: #D8BFD8; }
21-
.format { background-color: #FFE4B5; }
22-
.ranges { background-color: #7FFFD4; }
23-
.spaceship { background-color: #B0E0E6; }
24-
.fc { background-color: #8EAF63; white-space:nowrap; }
25-
.concurrency { background-color: #909090; white-space:nowrap; }
26-
.dr { background-color: #FFFF99; }
2720
</style>
2821

2922
.. role:: notstarted
@@ -40,21 +33,5 @@
4033
.. |Partial| replace:: :partial:`Partial`
4134
.. |Complete| replace:: :complete:`Complete`
4235

43-
.. role:: chrono
44-
.. role:: format
45-
.. role:: ranges
46-
.. role:: spaceship
47-
.. role:: fc
48-
.. role:: concurrency
49-
.. role:: dr
50-
51-
.. |chrono| replace:: :chrono:`chrono`
52-
.. |format| replace:: :format:`format`
53-
.. |ranges| replace:: :ranges:`ranges`
54-
.. |spaceship| replace:: :spaceship:`spaceship`
55-
.. |flat_containers| replace:: :fc:`flat containers`
56-
.. |concurrency TS| replace:: :concurrency:`concurrency TS`
57-
.. |DR| replace:: :dr:`Defect Report`
58-
5936
.. |sect| unicode:: U+00A7
6037
.. |hellip| unicode:: U+2026

libcxx/docs/Status/Cxx17Issues.csv

Lines changed: 314 additions & 314 deletions
Large diffs are not rendered by default.

libcxx/docs/Status/Cxx17Papers.csv

Lines changed: 113 additions & 113 deletions
Large diffs are not rendered by default.

libcxx/docs/Status/Cxx20Issues.csv

Lines changed: 302 additions & 302 deletions
Large diffs are not rendered by default.

libcxx/docs/Status/Cxx20Papers.csv

Lines changed: 206 additions & 206 deletions
Large diffs are not rendered by default.

libcxx/docs/Status/Cxx23Issues.csv

Lines changed: 308 additions & 308 deletions
Large diffs are not rendered by default.

libcxx/docs/Status/Cxx23Papers.csv

Lines changed: 123 additions & 123 deletions
Large diffs are not rendered by default.

libcxx/docs/Status/Cxx2cIssues.csv

Lines changed: 81 additions & 81 deletions
Large diffs are not rendered by default.

libcxx/docs/Status/Cxx2cPapers.csv

Lines changed: 78 additions & 78 deletions
Large diffs are not rendered by default.

libcxx/utils/synchronize_csv_status_files.py

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -140,12 +140,6 @@ class PaperInfo:
140140
First version of LLVM in which this paper/issue was resolved.
141141
"""
142142

143-
labels: Optional[List[str]]
144-
"""
145-
List of labels to associate to the issue in the status-tracking table. Supported labels are
146-
'format', 'ranges', 'spaceship', 'flat_containers', 'concurrency TS' and 'DR'.
147-
"""
148-
149143
original: Optional[object]
150144
"""
151145
Object from which this PaperInfo originated. This is used to track the CSV row or Github issue that
@@ -156,31 +150,28 @@ def __init__(self, paper_number: str, paper_name: str,
156150
status: PaperStatus,
157151
meeting: Optional[str] = None,
158152
first_released_version: Optional[str] = None,
159-
labels: Optional[List[str]] = None,
160153
original: Optional[object] = None):
161154
self.paper_number = paper_number
162155
self.paper_name = paper_name
163156
self.status = status
164157
self.meeting = meeting
165158
self.first_released_version = first_released_version
166-
self.labels = labels
167159
self.original = original
168160

169-
def for_printing(self) -> Tuple[str, str, str, str, str, str]:
161+
def for_printing(self) -> Tuple[str, str, str, str, str]:
170162
return (
171163
f'`{self.paper_number} <https://wg21.link/{self.paper_number}>`__',
172164
self.paper_name,
173165
self.meeting if self.meeting is not None else '',
174166
self.status.to_csv_entry(),
175167
self.first_released_version if self.first_released_version is not None else '',
176-
' '.join(f'|{label}|' for label in self.labels) if self.labels is not None else '',
177168
)
178169

179170
def __repr__(self) -> str:
180171
return repr(self.original) if self.original is not None else repr(self.for_printing())
181172

182173
@staticmethod
183-
def from_csv_row(row: Tuple[str, str, str, str, str, str]):# -> PaperInfo:
174+
def from_csv_row(row: Tuple[str, str, str, str, str]):# -> PaperInfo:
184175
"""
185176
Given a row from one of our status-tracking CSV files, create a PaperInfo object representing that row.
186177
"""
@@ -195,7 +186,6 @@ def from_csv_row(row: Tuple[str, str, str, str, str, str]):# -> PaperInfo:
195186
status=PaperStatus.from_csv_entry(row[3]),
196187
meeting=row[2] or None,
197188
first_released_version=row[4] or None,
198-
labels=[l.strip('|') for l in row[5].split(' ') if l] or None,
199189
original=row,
200190
)
201191

@@ -210,17 +200,12 @@ def from_github_issue(issue: Dict):# -> PaperInfo:
210200
raise RuntimeError(f"Issue doesn't have a title that we know how to parse: {issue}")
211201
paper = match.group(1)
212202

213-
# Handle labels
214-
valid_labels = ('format', 'ranges', 'spaceship', 'flat_containers', 'concurrency TS', 'DR')
215-
labels = [label for label in issue['labels'] if label in valid_labels]
216-
217203
return PaperInfo(
218204
paper_number=paper,
219205
paper_name=issue['title'],
220206
status=PaperStatus.from_github_issue(issue),
221207
meeting=issue.get('meeting Voted', None),
222208
first_released_version=None, # TODO
223-
labels=labels if labels else None,
224209
original=issue,
225210
)
226211

0 commit comments

Comments
 (0)