[lld] resolve dylib paths before caching

When loading frameworks it is possible to have load commands for the same
framework through symlinks and the real path. To avoid loading these multiple
times find the real path before checking the dylib cache.

Author: rmaz

lld/MachO/DriverUtils.cpp

@@ -26,6 +26,7 @@
 #include "llvm/Support/Path.h"
 #include "llvm/TextAPI/InterfaceFile.h"
 #include "llvm/TextAPI/TextAPIReader.h"
+#include <system_error>
 
 using namespace llvm;
 using namespace llvm::MachO;
@@ -229,7 +230,13 @@ static DenseMap<CachedHashStringRef, DylibFile *> loadedDylibs;
 
 DylibFile *macho::loadDylib(MemoryBufferRef mbref, DylibFile *umbrella,
                             bool isBundleLoader, bool explicitlyLinked) {
-  CachedHashStringRef path(mbref.getBufferIdentifier());
+  // Frameworks can be found from different symlink paths, so resolve
+  // symlinks before looking up in the dylib cache.
+  SmallString<128> realPath;
+  std::error_code err = fs::real_path(mbref.getBufferIdentifier(), realPath);
+  CachedHashStringRef path(err.value() == 0
+                               ? uniqueSaver().save(StringRef(realPath))
+                               : mbref.getBufferIdentifier());
   DylibFile *&file = loadedDylibs[path];
   if (file) {
     if (explicitlyLinked)