Skip to content

Commit bfb8a65

Browse files
committed
Typo and TODO
1 parent 0f957d1 commit bfb8a65

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1594,7 +1594,7 @@ bool SPIRVInstructionSelector::selectLog10(Register ResVReg,
15941594
// Build 0.30103.
15951595
assert(ResType->getOpcode() == SPIRV::OpTypeVector ||
15961596
ResType->getOpcode() == SPIRV::OpTypeFloat);
1597-
// TODO: Add matrix implementeation once supported by the HLSL frontend.
1597+
// TODO: Add matrix implementation once supported by the HLSL frontend.
15981598
const SPIRVType *SpirvScalarType =
15991599
ResType->getOpcode() == SPIRV::OpTypeVector
16001600
? GR.getSPIRVTypeForVReg(ResType->getOperand(1).getReg())

llvm/lib/Target/SPIRV/SPIRVLegalizerInfo.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -229,6 +229,10 @@ SPIRVLegalizerInfo::SPIRVLegalizerInfo(const SPIRVSubtarget &ST) {
229229
// Control-flow. In some cases (e.g. constants) s1 may be promoted to s32.
230230
getActionDefinitionsBuilder(G_BRCOND).legalFor({s1, s32});
231231

232+
// TODO: Review the target OpenCL and GLSL Extended Instruction Set specs to
233+
// tighten these requirements. Many of these math functions are only legal on
234+
// specific bitwidths, so they are not selectable for
235+
// allFloatScalarsAndVectors.
232236
getActionDefinitionsBuilder({G_FPOW,
233237
G_FEXP,
234238
G_FEXP2,

0 commit comments

Comments
 (0)