Skip to content

Commit b0f9a19

Browse files
committed
Address review comments
1 parent 87f2937 commit b0f9a19

File tree

2 files changed

+10
-28
lines changed

2 files changed

+10
-28
lines changed

clang/lib/Driver/ToolChains/Clang.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1756,24 +1756,18 @@ void Clang::AddAArch64TargetArgs(const ArgList &Args,
17561756

17571757
Args.addOptInFlag(CmdArgs, options::OPT_fptrauth_intrinsics,
17581758
options::OPT_fno_ptrauth_intrinsics);
1759-
17601759
Args.addOptInFlag(CmdArgs, options::OPT_fptrauth_calls,
17611760
options::OPT_fno_ptrauth_calls);
1762-
17631761
Args.addOptInFlag(CmdArgs, options::OPT_fptrauth_returns,
17641762
options::OPT_fno_ptrauth_returns);
1765-
17661763
Args.addOptInFlag(CmdArgs, options::OPT_fptrauth_auth_traps,
17671764
options::OPT_fno_ptrauth_auth_traps);
1768-
17691765
Args.addOptInFlag(
17701766
CmdArgs, options::OPT_fptrauth_vtable_pointer_address_discrimination,
17711767
options::OPT_fno_ptrauth_vtable_pointer_address_discrimination);
1772-
17731768
Args.addOptInFlag(
17741769
CmdArgs, options::OPT_fptrauth_vtable_pointer_type_discrimination,
17751770
options::OPT_fno_ptrauth_vtable_pointer_type_discrimination);
1776-
17771771
Args.addOptInFlag(CmdArgs, options::OPT_fptrauth_init_fini,
17781772
options::OPT_fno_ptrauth_init_fini);
17791773
}

clang/test/Driver/aarch64-ptrauth.c

Lines changed: 10 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -2,28 +2,16 @@
22
// NONE: "-cc1"
33
// NONE-NOT: "-fptrauth-
44

5-
// RUN: %clang -### -c --target=aarch64 -fno-ptrauth-intrinsics -fptrauth-intrinsics %s 2>&1 | FileCheck %s --check-prefix=INTRIN
6-
// INTRIN: "-cc1"{{.*}} "-fptrauth-intrinsics"
7-
8-
// RUN: %clang -### -c --target=aarch64 -fno-ptrauth-calls -fptrauth-calls %s 2>&1 | FileCheck %s --check-prefix=CALL
9-
// CALL: "-cc1"{{.*}} "-fptrauth-calls"
10-
11-
// RUN: %clang -### -c --target=aarch64 -fno-ptrauth-returns -fptrauth-returns %s 2>&1 | FileCheck %s --check-prefix=RETURN
12-
// RETURN: "-cc1"{{.*}} "-fptrauth-returns"
13-
14-
// RUN: %clang -### -c --target=aarch64 -fno-ptrauth-auth-traps -fptrauth-auth-traps %s 2>&1 | FileCheck %s --check-prefix=TRAP
15-
// TRAP: "-cc1"{{.*}} "-fptrauth-auth-traps"
16-
17-
// RUN: %clang -### -c --target=aarch64 -fno-ptrauth-vtable-pointer-address-discrimination \
18-
// RUN: -fptrauth-vtable-pointer-address-discrimination %s 2>&1 | FileCheck %s --check-prefix=VPTRADDR
19-
// VPTRADDR: "-cc1"{{.*}} "-fptrauth-vtable-pointer-address-discrimination"
20-
21-
// RUN: %clang -### -c --target=aarch64 -fno-ptrauth-vtable-pointer-type-discrimination \
22-
// RUN: -fptrauth-vtable-pointer-type-discrimination %s 2>&1 | FileCheck %s --check-prefix=VPTRTYPE
23-
// VPTRTYPE: "-cc1"{{.*}} "-fptrauth-vtable-pointer-type-discrimination"
24-
25-
// RUN: %clang -### -c --target=aarch64 -fno-ptrauth-init-fini -fptrauth-init-fini %s 2>&1 | FileCheck %s --check-prefix=INITFINI
26-
// INITFINI: "-cc1"{{.*}} "-fptrauth-init-fini"
5+
// RUN: %clang -### -c --target=aarch64 \
6+
// RUN: -fno-ptrauth-intrinsics -fptrauth-intrinsics \
7+
// RUN: -fno-ptrauth-calls -fptrauth-calls \
8+
// RUN: -fno-ptrauth-returns -fptrauth-returns \
9+
// RUN: -fno-ptrauth-auth-traps -fptrauth-auth-traps \
10+
// RUN: -fno-ptrauth-vtable-pointer-address-discrimination -fptrauth-vtable-pointer-address-discrimination \
11+
// RUN: -fno-ptrauth-vtable-pointer-type-discrimination -fptrauth-vtable-pointer-type-discrimination \
12+
// RUN: -fno-ptrauth-init-fini -fptrauth-init-fini \
13+
// RUN: %s 2>&1 | FileCheck %s --check-prefix=ALL
14+
// ALL: "-cc1"{{.*}} "-fptrauth-intrinsics" "-fptrauth-calls" "-fptrauth-returns" "-fptrauth-auth-traps" "-fptrauth-vtable-pointer-address-discrimination" "-fptrauth-vtable-pointer-type-discrimination" "-fptrauth-init-fini"
2715

2816
// RUN: not %clang -### -c --target=x86_64 -fptrauth-intrinsics -fptrauth-calls -fptrauth-returns -fptrauth-auth-traps \
2917
// RUN: -fptrauth-vtable-pointer-address-discrimination -fptrauth-vtable-pointer-type-discrimination \

0 commit comments

Comments
 (0)