Skip to content

Commit b07e7b7

Browse files
authored
[cmake] Drop AddFileDependencies and CMakeParseArguments (#120002)
Theses modules are deprecated and have trivial implementations in modern cmake.
1 parent 37e48e4 commit b07e7b7

File tree

8 files changed

+3
-13
lines changed

8 files changed

+3
-13
lines changed

clang/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,6 @@ if (APPLE AND NOT CMAKE_LINKER MATCHES ".*lld.*")
362362
message(STATUS "Host linker version: ${HOST_LINK_VERSION}")
363363
endif()
364364

365-
include(CMakeParseArguments)
366365
include(AddClang)
367366

368367
set(CMAKE_INCLUDE_CURRENT_DIR ON)

compiler-rt/cmake/Modules/CompilerRTAIXUtils.cmake

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
include(CMakeParseArguments)
21
include(CompilerRTUtils)
32

43
function(get_aix_libatomic_default_link_flags link_flags export_list)

compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
include(CMakeParseArguments)
21
include(CompilerRTUtils)
32
include(BuiltinTests)
43

flang/CMakeLists.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,6 @@ if (FLANG_STANDALONE_BUILD)
117117
set(USE_NO_MAYBE_UNINITIALIZED 1)
118118
endif()
119119

120-
include(CMakeParseArguments)
121120
include(AddLLVM)
122121
include(HandleLLVMOptions)
123122
include(VersionFromVCS)
@@ -445,7 +444,6 @@ if (APPLE)
445444
endif()
446445
endif()
447446

448-
include(CMakeParseArguments)
449447
include(AddFlang)
450448

451449
if (FLANG_INCLUDE_TESTS)

libc/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,6 @@ endif()
329329

330330
option(LIBC_INCLUDE_DOCS "Build the libc documentation." ${LLVM_INCLUDE_DOCS})
331331

332-
include(CMakeParseArguments)
333332
include(LLVMLibCCheckCpuFeatures)
334333
include(CheckCompilerFeatures)
335334
include(LLVMLibCRules)

llvm/cmake/modules/LLVMProcessSources.cmake

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
include(AddFileDependencies)
2-
include(CMakeParseArguments)
3-
41
function(llvm_replace_compiler_option var old new)
52
# Replaces a compiler option or switch `old' in `var' by `new'.
63
# If `old' is not in `var', appends `new' to `var'.

llvm/tools/llvm-config/CMakeLists.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,9 @@ if(LLVM_ENABLE_MODULES)
8989
endif()
9090

9191
# Add the dependency on the generation step.
92-
add_file_dependencies(${CMAKE_CURRENT_SOURCE_DIR}/llvm-config.cpp ${BUILDVARIABLES_OBJPATH})
92+
set_property(SOURCE ${CMAKE_CURRENT_SOURCE_DIR}/llvm-config.cpp
93+
APPEND PROPERTY OBJECT_DEPENDS ${BUILDVARIABLES_OBJPATH}
94+
)
9395

9496
if(CMAKE_CROSSCOMPILING)
9597
if (LLVM_NATIVE_TOOL_DIR AND NOT LLVM_CONFIG_PATH)

polly/cmake/polly_macros.cmake

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
2-
include(CMakeParseArguments)
3-
41
macro(add_polly_library name)
52
cmake_parse_arguments(ARG "" "" "" ${ARGN})
63
set(srcs ${ARG_UNPARSED_ARGUMENTS})

0 commit comments

Comments
 (0)