Skip to content

Commit 95b3fd6

Browse files
committed
[lldb][test] Fix TestFrameFunctionInlined on Windows
This test was timing out on Linaro's Windows on Arm bot. This was because it couldn't identify an inlined function to break on, which let it run into an infinite loop, which exhausted the stack, which would have taken forever to backtrace. Full details here - #143104 I'm not sure PDB would help here but it does work with DWARF as long as we use a linker that keeps it. So I've changed the test to require Windows and lld, unless you're not on Windows and then you can use any linker. Also I had to regex some parts of the function name because on Windows we get the return and parameter types too.
1 parent c95bc41 commit 95b3fd6

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

lldb/test/Shell/Settings/TestFrameFunctionInlined.test

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,12 @@
11
# Test the ${function.is-inlined} frame-format variable.
22

3+
# Windows' link.exe does not preserve DWARF information, and we cannot get
4+
# inlining information from PDB at this time, see:
5+
# https://github.com/llvm/llvm-project/issues/143104
6+
# REQUIRES: (system-windows && lld) || !system-windows
7+
38
# RUN: split-file %s %t
4-
# RUN: %clang_host -g -gdwarf %t/main.cpp -o %t.out
9+
# RUN: %clang_host -g -gdwarf %t/main.cpp -o %t.out %if system-windows %{-fuse-ld=lld%}
510
# RUN: %lldb -x -b -s %t/commands.input %t.out -o exit 2>&1 \
611
# RUN: | FileCheck %s
712

@@ -28,7 +33,7 @@ run
2833
bt
2934

3035
# CHECK: (lldb) bt
31-
# CHECK: frame 'inlined1() (Inlined)'
32-
# CHECK-NEXT: frame 'regular()'
33-
# CHECK-NEXT: frame 'inlined2() (Inlined)'
36+
# CHECK: frame '{{.*}}inlined1({{.*}}) (Inlined)'
37+
# CHECK-NEXT: frame '{{.*}}regular({{.*}})'
38+
# CHECK-NEXT: frame '{{.*}}inlined2({{.*}}) (Inlined)'
3439
# CHECK-NEXT: frame 'main'

0 commit comments

Comments
 (0)