Skip to content

Commit 9347146

Browse files
authored
Document use of skip-precommit-approval label for non-review pull requests (#81053)
Derived from this discussion: https://discourse.llvm.org/t/prs-without-approvals-muddy-the-waters/76656
1 parent 2572f45 commit 9347146

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

llvm/docs/CodeReview.rst

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,12 @@ ready to be committed. Specifically, once a patch is sent out for review, it
103103
needs an explicit approval before it is committed. Do not assume silent
104104
approval, or solicit objections to a patch with a deadline.
105105

106+
.. note::
107+
If you are using a Pull Request for purposes other than review
108+
(eg: precommit CI results, convenient web-based reverts, etc)
109+
`skip-precommit-approval<https://github.com/llvm/llvm-project/labels?q=skip-precommit-approval>`
110+
label to the PR.
111+
106112
Acknowledge All Reviewer Feedback
107113
---------------------------------
108114

llvm/docs/GitHub.rst

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,12 @@ describes the typical workflow of creating a Pull Request and getting it reviewe
3030
and accepted. This is meant as an overview of the GitHub workflow, for complete
3131
documentation refer to `GitHub's documentation <https://docs.github.com/pull-requests>`_.
3232

33+
.. note::
34+
If you are using a Pull Request for purposes other than review
35+
(eg: precommit CI results, convenient web-based reverts, etc)
36+
`skip-precommit-approval<https://github.com/llvm/llvm-project/labels?q=skip-precommit-approval>`
37+
label to the PR.
38+
3339
GitHub Tools
3440
------------
3541
You can interact with GitHub in several ways: via git command line tools,

0 commit comments

Comments
 (0)