File tree 1 file changed +9
-11
lines changed 1 file changed +9
-11
lines changed Original file line number Diff line number Diff line change @@ -402,15 +402,18 @@ For your first patches, this means:
402
402
opinion.
403
403
404
404
405
- Accepting a revision
406
- ~~~~~~~~~~~~~~~~~~~~
405
+ Accepting a pull request
406
+ ------------------------
407
407
408
408
When the reviewer is happy with the change, they will **Approve ** the
409
409
pull request. They may leave some more minor comments that you should
410
410
address before it is merged, but at this point the review is complete.
411
411
It's time to get it merged!
412
412
413
413
414
+ Commit access
415
+ =============
416
+
414
417
Commit by proxy
415
418
---------------
416
419
@@ -423,8 +426,8 @@ them! Leave a comment on the review like:
423
426
424
427
The pull-request will be closed and you will be notified by GitHub.
425
428
426
- Commit access
427
- =============
429
+ Getting commit access
430
+ ---------------------
428
431
429
432
Once you've contributed a handful of patches to LLVM, start to think
430
433
about getting commit access yourself. It's probably a good idea if:
@@ -436,12 +439,7 @@ about getting commit access yourself. It's probably a good idea if:
436
439
- you'd like to keep contributing to LLVM.
437
440
438
441
439
- Getting commit access
440
- ---------------------
441
-
442
- LLVM uses Git for committing changes. The details are in the
443
- :ref: `developer policy document <obtaining_commit_access >`.
444
-
442
+ The process is described in the :ref: `developer policy document <obtaining_commit_access >`.
445
443
446
444
With great power
447
445
----------------
@@ -451,7 +449,7 @@ policy <developer_policy>` too.
451
449
452
450
453
451
Post-commit errors
454
- ------------------
452
+ ==================
455
453
456
454
Once your change is submitted it will be picked up by automated build
457
455
bots that will build and test your patch in a variety of configurations.
You can’t perform that action at this time.
0 commit comments