Skip to content

Commit 776ac21

Browse files
authored
[mlir] minor documentation fix in GPUTransformOps.td (#121157)
- do not refer to handles as `PDLOperation`, this is an outdated and incorrect vision of what they are based on the type used in the early days; - use backticks around inline code.
1 parent 62c39d7 commit 776ac21

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

mlir/include/mlir/Dialect/GPU/TransformOps/GPUTransformOps.td

+5-5
Original file line numberDiff line numberDiff line change
@@ -168,13 +168,13 @@ def MapNestedForallToThreads :
168168

169169
#### Return modes:
170170

171-
This operation ignores non-gpu_launch ops and drops them in the return.
171+
This operation ignores non-`gpu_launch` ops and drops them in the return.
172172

173173
If any scf.forall with tensors is found, the transform definitely
174174
fails.
175175

176-
If all the scf.forall operations with gpu.thread mapping contained
177-
within the LaunchOp referred to by the `target` PDLOperation lower to GPU
176+
If all the `scf.forall` operations with gpu.thread mapping contained
177+
within the `LaunchOp` referred to by the `target` handle lower to GPU
178178
properly, the transform succeeds. Otherwise the transform definitely
179179
fails.
180180

@@ -277,8 +277,8 @@ def MapForallToBlocks :
277277
If any scf.forall with tensors is found, the transform definitely
278278
fails.
279279

280-
If all the scf.forall operations contained within the LaunchOp
281-
referred to by the `target` PDLOperation lower to GPU properly, the
280+
If all the `scf.forall` operations contained within the LaunchOp
281+
referred to by the `target` handle lower to GPU properly, the
282282
transform succeeds. Otherwise the transform definitely fails.
283283

284284
The returned handle points to the same LaunchOp operand, consuming it and

0 commit comments

Comments
 (0)