Skip to content

Commit 7595287

Browse files
authored
[lldb] Remove obsolete signBinary helper (#79656)
On Darwin, the Makefile already (ad-hoc) signs everything it builds. There's also no need to use lldb_codesign for this.
1 parent 701ec45 commit 7595287

File tree

8 files changed

+0
-26
lines changed

8 files changed

+0
-26
lines changed

lldb/packages/Python/lldbsuite/test/dotest.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -442,8 +442,6 @@ def parseOptionsAndInitTestdirs():
442442
os.path.realpath(os.path.abspath(x)) for x in args.args
443443
]
444444

445-
lldbtest_config.codesign_identity = args.codesign_identity
446-
447445

448446
def registerFaulthandler():
449447
try:

lldb/packages/Python/lldbsuite/test/dotest_args.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -217,12 +217,6 @@ def create_parser():
217217
action="store_true",
218218
help="Leave logs/traces even for successful test runs (useful for creating reference log files during debugging.)",
219219
)
220-
group.add_argument(
221-
"--codesign-identity",
222-
metavar="Codesigning identity",
223-
default="lldb_codesign",
224-
help="The codesigning identity to use",
225-
)
226220
group.add_argument(
227221
"--build-dir",
228222
dest="test_build_dir",

lldb/packages/Python/lldbsuite/test/lldbtest.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1543,14 +1543,6 @@ def buildProgram(self, sources, exe_name):
15431543
d = {"CXX_SOURCES": sources, "EXE": exe_name}
15441544
self.build(dictionary=d)
15451545

1546-
def signBinary(self, binary_path):
1547-
if sys.platform.startswith("darwin"):
1548-
codesign_cmd = 'codesign --force --sign "%s" %s' % (
1549-
lldbtest_config.codesign_identity,
1550-
binary_path,
1551-
)
1552-
call(codesign_cmd, shell=True)
1553-
15541546
def findBuiltClang(self):
15551547
"""Tries to find and use Clang from the build directory as the compiler (instead of the system compiler)."""
15561548
paths_to_try = [

lldb/test/API/CMakeLists.txt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -98,12 +98,6 @@ if(CMAKE_HOST_APPLE)
9898
set(LLDB_FRAMEWORK_DIR ${LLDB_FRAMEWORK_ABSOLUTE_BUILD_DIR}/LLDB.framework)
9999
endif()
100100

101-
# Use the same identity for testing
102-
get_property(code_sign_identity_used GLOBAL PROPERTY LLDB_DEBUGSERVER_CODESIGN_IDENTITY)
103-
if(code_sign_identity_used)
104-
list(APPEND LLDB_TEST_COMMON_ARGS_VAR --codesign-identity "${code_sign_identity_used}")
105-
endif()
106-
107101
if(LLDB_USE_SYSTEM_DEBUGSERVER)
108102
lldb_find_system_debugserver(system_debugserver_path)
109103
if(LLDB_BUILD_FRAMEWORK)

lldb/test/API/api/command-return-object/TestSBCommandReturnObject.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ def test_sb_command_return_object(self):
1818
self.driver_exe = self.getBuildArtifact("command-return-object")
1919
self.buildDriver("main.cpp", self.driver_exe)
2020
self.addTearDownHook(lambda: os.remove(self.driver_exe))
21-
self.signBinary(self.driver_exe)
2221

2322
if self.TraceOn():
2423
print("Running test %s" % self.driver_exe)

lldb/test/API/api/multiple-debuggers/TestMultipleDebuggers.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ def test_multiple_debuggers(self):
2424
self.driver_exe = self.getBuildArtifact("multi-process-driver")
2525
self.buildDriver("multi-process-driver.cpp", self.driver_exe)
2626
self.addTearDownHook(lambda: os.remove(self.driver_exe))
27-
self.signBinary(self.driver_exe)
2827

2928
self.inferior_exe = self.getBuildArtifact("testprog")
3029
self.buildDriver("testprog.cpp", self.inferior_exe)

lldb/test/API/api/multiple-targets/TestMultipleTargets.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ def test_multiple_targets(self):
2424
self.driver_exe = self.getBuildArtifact("multi-target")
2525
self.buildDriver("main.cpp", self.driver_exe)
2626
self.addTearDownHook(lambda: os.remove(self.driver_exe))
27-
self.signBinary(self.driver_exe)
2827

2928
# check_call will raise a CalledProcessError if multi-process-driver doesn't return
3029
# exit code 0 to indicate success. We can let this exception go - the test harness

lldb/test/API/api/multithreaded/TestMultithreaded.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,6 @@ def build_and_test(self, sources, test_name, args=None):
106106
self.addTearDownHook(lambda: os.remove(self.getBuildArtifact(test_name)))
107107

108108
test_exe = self.getBuildArtifact(test_name)
109-
self.signBinary(test_exe)
110109
exe = [test_exe, self.getBuildArtifact(self.inferior)]
111110

112111
env = {self.dylibPath: self.getLLDBLibraryEnvVal()}

0 commit comments

Comments
 (0)