Skip to content

Commit 72a74e4

Browse files
tstellartru
authored andcommitted
workflows/release-tasks: Pass required secrets to all called workflows (#106286)
Called workflows don't have access to secrets by default, so we need to explicitly pass secrets that we use. (cherry picked from commit 9d81e7e)
1 parent bac3db3 commit 72a74e4

File tree

4 files changed

+28
-2
lines changed

4 files changed

+28
-2
lines changed

.github/workflows/release-doxygen.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,10 @@ on:
2525
description: 'Upload documentation'
2626
required: false
2727
type: boolean
28+
secrets:
29+
RELEASE_TASKS_USER_TOKEN:
30+
description: "Secret used to check user permissions."
31+
required: false
2832

2933
jobs:
3034
release-doxygen:
@@ -63,5 +67,6 @@ jobs:
6367
if: env.upload
6468
env:
6569
GITHUB_TOKEN: ${{ github.token }}
70+
USER_TOKEN: ${{ secrets.RELEASE_TASKS_USER_TOKEN }}
6671
run: |
67-
./llvm/utils/release/github-upload-release.py --token "$GITHUB_TOKEN" --release "${{ inputs.release-version }}" --user "${{ github.actor }}" upload --files ./*doxygen*.tar.xz
72+
./llvm/utils/release/github-upload-release.py --token "$GITHUB_TOKEN" --release "${{ inputs.release-version }}" --user "${{ github.actor }}" --user-token "$USER_TOKEN" upload --files ./*doxygen*.tar.xz

.github/workflows/release-lit.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,10 @@ on:
1717
description: 'Release Version'
1818
required: true
1919
type: string
20+
secrets:
21+
RELEASE_TASKS_USER_TOKEN:
22+
description: "Secret used to check user permissions."
23+
required: false
2024

2125
jobs:
2226
release-lit:
@@ -36,8 +40,9 @@ jobs:
3640
- name: Check Permissions
3741
env:
3842
GITHUB_TOKEN: ${{ github.token }}
43+
USER_TOKEN: ${{ secrets.RELEASE_TASKS_USER_TOKEN }}
3944
run: |
40-
./llvm/utils/release/./github-upload-release.py --token "$GITHUB_TOKEN" --user ${{ github.actor }} check-permissions
45+
./llvm/utils/release/./github-upload-release.py --token "$GITHUB_TOKEN" --user ${{ github.actor }} --user-token "$USER_TOKEN" check-permissions
4146
4247
- name: Setup Cpp
4348
uses: aminya/setup-cpp@v1

.github/workflows/release-sources.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ on:
1616
description: Release Version
1717
required: true
1818
type: string
19+
secrets:
20+
RELEASE_TASKS_USER_TOKEN:
21+
description: "Secret used to check user permissions."
22+
required: false
1923
# Run on pull_requests for testing purposes.
2024
pull_request:
2125
paths:

.github/workflows/release-tasks.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,13 +66,19 @@ jobs:
6666
with:
6767
release-version: ${{ needs.validate-tag.outputs.release-version }}
6868
upload: true
69+
# Called workflows don't have access to secrets by default, so we need to explicitly pass secrets that we use.
70+
secrets:
71+
RELEASE_TASKS_USER_TOKEN: ${{ secrets.RELEASE_TASKS_USER_TOKEN }}
6972

7073
release-lit:
7174
name: Release Lit
7275
needs: validate-tag
7376
uses: ./.github/workflows/release-lit.yml
7477
with:
7578
release-version: ${{ needs.validate-tag.outputs.release-version }}
79+
# Called workflows don't have access to secrets by default, so we need to explicitly pass secrets that we use.
80+
secrets:
81+
RELEASE_TASKS_USER_TOKEN: ${{ secrets.RELEASE_TASKS_USER_TOKEN }}
7682

7783
release-binaries:
7884
name: Build Release Binaries
@@ -97,6 +103,9 @@ jobs:
97103
release-version: ${{ needs.validate-tag.outputs.release-version }}
98104
upload: true
99105
runs-on: ${{ matrix.runs-on }}
106+
# Called workflows don't have access to secrets by default, so we need to explicitly pass secrets that we use.
107+
secrets:
108+
RELEASE_TASKS_USER_TOKEN: ${{ secrets.RELEASE_TASKS_USER_TOKEN }}
100109

101110
release-sources:
102111
name: Package Release Sources
@@ -109,3 +118,6 @@ jobs:
109118
uses: ./.github/workflows/release-sources.yml
110119
with:
111120
release-version: ${{ needs.validate-tag.outputs.release-version }}
121+
# Called workflows don't have access to secrets by default, so we need to explicitly pass secrets that we use.
122+
secrets:
123+
RELEASE_TASKS_USER_TOKEN: ${{ secrets.RELEASE_TASKS_USER_TOKEN }}

0 commit comments

Comments
 (0)