Skip to content

Commit 6900768

Browse files
[mlir][Conversion] Fix typos in MemRef descriptor comments (#124923)
1 parent 4fc514a commit 6900768

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

mlir/include/mlir/Conversion/LLVMCommon/MemRefBuilder.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ class MemRefDescriptor : public StructBuilder {
104104
/// - aligned pointer;
105105
/// - offset;
106106
/// - <rank> sizes;
107-
/// - <rank> shapes;
107+
/// - <rank> strides;
108108
/// where <rank> is the MemRef rank as provided in `type`.
109109
static Value pack(OpBuilder &builder, Location loc,
110110
const LLVMTypeConverter &converter, MemRefType type,

mlir/lib/Conversion/LLVMCommon/MemRefBuilder.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ Value MemRefDescriptor::bufferPtr(OpBuilder &builder, Location loc,
218218
/// - aligned pointer;
219219
/// - offset;
220220
/// - <rank> sizes;
221-
/// - <rank> shapes;
221+
/// - <rank> strides;
222222
/// where <rank> is the MemRef rank as provided in `type`.
223223
Value MemRefDescriptor::pack(OpBuilder &builder, Location loc,
224224
const LLVMTypeConverter &converter,
@@ -260,7 +260,7 @@ void MemRefDescriptor::unpack(OpBuilder &builder, Location loc, Value packed,
260260
/// Returns the number of non-aggregate values that would be produced by
261261
/// `unpack`.
262262
unsigned MemRefDescriptor::getNumUnpackedValues(MemRefType type) {
263-
// Two pointers, offset, <rank> sizes, <rank> shapes.
263+
// Two pointers, offset, <rank> sizes, <rank> strides.
264264
return 3 + 2 * type.getRank();
265265
}
266266

0 commit comments

Comments
 (0)