Skip to content

Commit 6886a52

Browse files
Revert "[libc] build with -Werror (#73966)"
This reverts commit 6066530. Post submit buildbots are now red. We can use these explicit errors to better clean up existing warnings, then reland this. Link: #73966
1 parent 47fe9fc commit 6886a52

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

libc/cmake/modules/LLVMLibCObjectRules.cmake

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,6 @@ function(_get_common_compile_options output_var flags)
4343
list(APPEND compile_options "-fno-rtti")
4444
list(APPEND compile_options "-Wall")
4545
list(APPEND compile_options "-Wextra")
46-
# -DLIBC_WNO_ERROR=ON if you can't build cleanly with -Werror.
47-
if(NOT LIBC_WNO_ERROR)
48-
list(APPEND compile_options "-Werror")
49-
endif()
5046
list(APPEND compile_options "-Wconversion")
5147
list(APPEND compile_options "-Wno-sign-conversion")
5248
list(APPEND compile_options "-Wimplicit-fallthrough")

libc/docs/dev/code_style.rst

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -178,11 +178,3 @@ these functions do not call the constructors and destructors of the
178178
allocated/deallocated objects. So, use these functions carefully and only
179179
when it is absolutely clear that constructor and destructor invocation is
180180
not required.
181-
182-
Warnings in sources
183-
===================
184-
185-
We expect contributions to be free of warnings from the `minimum supported
186-
compiler versions`__ (and newer).
187-
188-
.. __: https://libc.llvm.org/compiler_support.html#minimum-supported-versions

0 commit comments

Comments
 (0)