Skip to content

Commit 67f9c35

Browse files
author
Tacet
authored
Make two texts static in ReplayInlineAdvisor (#79489)
This commit makes two variables static. That makes two buildbot tests pass with short string annotations. I suspect that there may be use after end of life bug and it's fixed by this change, but it requires confirmation. Short string annotations PR (reverted): - #79049 Tests fixed with this PR: ``` LLVM :: Transforms/Inline/cgscc-inline-replay.ll LLVM :: Transforms/SampleProfile/inline-replay.ll ``` Buildbot output: https://lab.llvm.org/buildbot/#/builders/5/builds/40364/steps/9/logs/stdio This PR does not resolve a problem with `Clang :: SemaCXX/builtins.cpp`, related PR is: - #79522
1 parent edb7206 commit 67f9c35

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

llvm/lib/Analysis/ReplayInlineAdvisor.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ ReplayInlineAdvisor::ReplayInlineAdvisor(
4343
// main:3:1.1;
4444
// We use the callsite string after `at callsite` to replay inlining.
4545
line_iterator LineIt(*BufferOrErr.get(), /*SkipBlanks=*/true);
46-
const std::string PositiveRemark = "' inlined into '";
47-
const std::string NegativeRemark = "' will not be inlined into '";
46+
static const std::string PositiveRemark = "' inlined into '";
47+
static const std::string NegativeRemark = "' will not be inlined into '";
4848

4949
for (; !LineIt.is_at_eof(); ++LineIt) {
5050
StringRef Line = *LineIt;

0 commit comments

Comments
 (0)