Skip to content

Commit 66400fc

Browse files
committed
[ConstraintElimination] Support add with precondition.
If we can prove that an addition without wrap flags won't wrap, decompse the operation. Issue #48253
1 parent f9f78a2 commit 66400fc

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

llvm/lib/Transforms/Scalar/ConstraintElimination.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -229,6 +229,12 @@ decompose(Value *V, SmallVector<PreconditionTy, 4> &Preconditions,
229229
ConstantInt *CI;
230230
if (match(V, m_NUWAdd(m_Value(Op0), m_ConstantInt(CI))))
231231
return {{CI->getSExtValue(), nullptr}, {1, Op0}};
232+
if (match(V, m_Add(m_Value(Op0), m_ConstantInt(CI))) && CI->isNegative()) {
233+
Preconditions.emplace_back(
234+
CmpInst::ICMP_UGE, Op0,
235+
ConstantInt::get(Op0->getType(), CI->getSExtValue() * -1));
236+
return {{CI->getSExtValue(), nullptr}, {1, Op0}};
237+
}
232238
if (match(V, m_NUWAdd(m_Value(Op0), m_Value(Op1))))
233239
return {{0, nullptr}, {1, Op0}, {1, Op1}};
234240

llvm/test/Transforms/ConstraintElimination/wrapping-math.ll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ define i1 @wrapping_add_known_1(i8 %a) {
2222
; CHECK: then:
2323
; CHECK-NEXT: [[SUB_1:%.*]] = add i8 [[A]], -1
2424
; CHECK-NEXT: [[C_1:%.*]] = icmp eq i8 [[SUB_1]], 0
25-
; CHECK-NEXT: ret i1 [[C_1]]
25+
; CHECK-NEXT: ret i1 true
2626
; CHECK: else:
2727
; CHECK-NEXT: [[SUB_2:%.*]] = add i8 [[A]], -1
2828
; CHECK-NEXT: [[C_2:%.*]] = icmp eq i8 [[SUB_2]], 0
@@ -85,7 +85,7 @@ define i1 @test_48253_eq_ne(i8 %a, i8 %b) {
8585
; CHECK-NEXT: [[T_1:%.*]] = icmp ult i8 [[SUB_1]], [[A]]
8686
; CHECK-NEXT: [[SUB_2:%.*]] = add i8 [[B]], -2
8787
; CHECK-NEXT: [[C_2:%.*]] = icmp ult i8 [[SUB_2]], [[A]]
88-
; CHECK-NEXT: [[XOR_1:%.*]] = xor i1 [[T_1]], [[C_2]]
88+
; CHECK-NEXT: [[XOR_1:%.*]] = xor i1 true, [[C_2]]
8989
; CHECK-NEXT: ret i1 [[XOR_1]]
9090
; CHECK: exit.1:
9191
; CHECK-NEXT: [[SUB_3:%.*]] = add i8 [[B]], -1
@@ -133,9 +133,9 @@ define i1 @test_ult(i8 %a, i8 %b) {
133133
; CHECK: if.end:
134134
; CHECK-NEXT: [[T_1:%.*]] = icmp ult i8 [[SUB_1]], [[B]]
135135
; CHECK-NEXT: [[T_2:%.*]] = icmp ult i8 [[SUB_2]], [[B]]
136-
; CHECK-NEXT: [[XOR_1:%.*]] = xor i1 [[T_1]], [[T_2]]
136+
; CHECK-NEXT: [[XOR_1:%.*]] = xor i1 true, true
137137
; CHECK-NEXT: [[T_3:%.*]] = icmp ult i8 [[SUB_3]], [[B]]
138-
; CHECK-NEXT: [[XOR_2:%.*]] = xor i1 [[XOR_1]], [[T_3]]
138+
; CHECK-NEXT: [[XOR_2:%.*]] = xor i1 [[XOR_1]], true
139139
; CHECK-NEXT: [[C_1:%.*]] = icmp ult i8 [[SUB_4]], [[B]]
140140
; CHECK-NEXT: [[XOR_3:%.*]] = xor i1 [[XOR_2]], [[C_1]]
141141
; CHECK-NEXT: [[C_2:%.*]] = icmp ult i8 [[ADD_1]], [[B]]

0 commit comments

Comments
 (0)