Skip to content

Commit 65f40cb

Browse files
[ModuleInliner] Remove an inapplicable comment
The module inliner has its own logic in deciding the order in which call sites are inlined, so the comment is inapplicable.
1 parent bdc2771 commit 65f40cb

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

llvm/lib/Transforms/IPO/ModuleInliner.cpp

-5
Original file line numberDiff line numberDiff line change
@@ -144,11 +144,6 @@ PreservedAnalyses ModuleInlinerPass::run(Module &M,
144144
// Populate the initial list of calls in this module.
145145
for (Function &F : M) {
146146
auto &ORE = FAM.getResult<OptimizationRemarkEmitterAnalysis>(F);
147-
// We want to generally process call sites top-down in order for
148-
// simplifications stemming from replacing the call with the returned value
149-
// after inlining to be visible to subsequent inlining decisions.
150-
// FIXME: Using instructions sequence is a really bad way to do this.
151-
// Instead we should do an actual RPO walk of the function body.
152147
for (Instruction &I : instructions(F))
153148
if (auto *CB = dyn_cast<CallBase>(&I))
154149
if (Function *Callee = CB->getCalledFunction()) {

0 commit comments

Comments
 (0)