Skip to content

Commit 59a427a

Browse files
committed
[GitHub] Add python 3.7 to libclang python test
This enables the libclang python binding test to check the oldest version of Python supported in addition to the normal python version. It is important to check this for issue #76664, since many new mainstream python type annotation features and best practices are not compatible with older versions of python. Additionally, frustration around ever increasing platform dependencies and versions has been raised. This will help ensure that python maintains reasonable backwards compatibility. Adding this additional build step will increase the run time, but this should always be minimal, since the additional libclang compilation should see 100% cache hit rate. Issue #76664. Fixes #76601.
1 parent 5b35d6c commit 59a427a

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

.github/workflows/libclang-python-tests.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,15 @@ jobs:
3030
check-clang-python:
3131
# Build libclang and then run the libclang Python binding's unit tests.
3232
name: Build and run Python unit tests
33+
strategy:
34+
fail-fast: false
35+
matrix:
36+
python-version: ["3.7", "3.11"]
3337
uses: ./.github/workflows/llvm-project-tests.yml
3438
with:
3539
build_target: check-clang-python
3640
projects: clang
3741
# There is an issue running on "windows-2019".
3842
# See https://github.com/llvm/llvm-project/issues/76601#issuecomment-1873049082.
3943
os_list: '["ubuntu-latest"]'
44+
python_version: ${{ matrix.python-version }}

0 commit comments

Comments
 (0)