Apply clang-tidy fixes for performance-move-const-arg in Utils.cpp (NFC)

joker-eph · joker-eph · commit 4d3ba7a0b24b · 2023-01-03T09:45:39.000Z
diff --git a/mlir/lib/Dialect/Transform/Utils/Utils.cpp b/mlir/lib/Dialect/Transform/Utils/Utils.cpp
@@ -36,7 +36,7 @@ ParseResult transform::parsePackedOrDynamicIndexList(
     DenseI64ArrayAttr &integers) {
   OpAsmParser::UnresolvedOperand packedOperand;
   if (parser.parseOptionalOperand(packedOperand).has_value()) {
-    packed.emplace(std::move(packedOperand));
+    packed.emplace(packedOperand);
     integers = parser.getBuilder().getDenseI64ArrayAttr({});
     return success();
   }

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ ParseResult transform::parsePackedOrDynamicIndexList(`
`36`	`36`	`DenseI64ArrayAttr &integers) {`
`37`	`37`	`OpAsmParser::UnresolvedOperand packedOperand;`
`38`	`38`	`if (parser.parseOptionalOperand(packedOperand).has_value()) {`
`39`		`- packed.emplace(std::move(packedOperand));`
	`39`	`+ packed.emplace(packedOperand);`
`40`	`40`	`integers = parser.getBuilder().getDenseI64ArrayAttr({});`
`41`	`41`	`return success();`
`42`	`42`	`}`