Skip to content

Commit 3f0d52b

Browse files
committed
[mlir][llvm] Clean out f8 types from compatible types list
These were added in faf697e so things can flow through non-opaque LLVM ptrs. Those ptrs are gone so there is no reason for this to be around anymore. LLVM doesn't support f8 types, they get converted to i8 when lowering to LLVM dialect. Removing the f8 types makes LLVM::isCompatibleType and LLVM::isCompatibleFloatingPointType consistent again.
1 parent 652ae4e commit 3f0d52b

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

mlir/lib/Dialect/LLVMIR/IR/LLVMTypes.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -769,8 +769,6 @@ bool mlir::LLVM::isCompatibleOuterType(Type type) {
769769
Float64Type,
770770
Float80Type,
771771
Float128Type,
772-
Float8E4M3FNType,
773-
Float8E5M2Type,
774772
LLVMArrayType,
775773
LLVMFunctionType,
776774
LLVMLabelType,
@@ -841,8 +839,6 @@ static bool isCompatibleImpl(Type type, DenseSet<Type> &compatibleTypes) {
841839
Float64Type,
842840
Float80Type,
843841
Float128Type,
844-
Float8E4M3FNType,
845-
Float8E5M2Type,
846842
LLVMLabelType,
847843
LLVMMetadataType,
848844
LLVMPPCFP128Type,

0 commit comments

Comments
 (0)