Skip to content

Commit 37a7ec4

Browse files
committed
Rename helper function
1 parent e914e86 commit 37a7ec4

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

llvm/include/llvm/Transforms/Utils/LowerAtomic.h

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,9 @@ bool lowerAtomicCmpXchgInst(AtomicCmpXchgInst *CXI);
2525

2626
/// Emit IR to implement the given cmpxchg operation on values in registers,
2727
/// returning the new value.
28-
std::pair<Value *, Value *> buildAtomicCmpXchgValue(IRBuilderBase &Builder,
29-
Value *Ptr, Value *Cmp,
30-
Value *Val,
31-
Align Alignment);
28+
std::pair<Value *, Value *> buildCmpXchgValue(IRBuilderBase &Builder,
29+
Value *Ptr, Value *Cmp,
30+
Value *Val, Align Alignment);
3231

3332
/// Convert the given RMWI into primitive load and stores,
3433
/// assuming that doing so is legal. Return true if the lowering

llvm/lib/Target/AMDGPU/SIISelLowering.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16895,8 +16895,8 @@ void SITargetLowering::emitExpandAtomicAddrSpacePredicate(
1689516895
Builder.CreateAlignedStore(NewVal, CastToPrivate, RMW->getAlign());
1689616896
} else {
1689716897
auto [ResultLoad, Equal] =
16898-
buildAtomicCmpXchgValue(Builder, CastToPrivate, CX->getCompareOperand(),
16899-
CX->getNewValOperand(), CX->getAlign());
16898+
buildCmpXchgValue(Builder, CastToPrivate, CX->getCompareOperand(),
16899+
CX->getNewValOperand(), CX->getAlign());
1690016900

1690116901
Value *Insert = Builder.CreateInsertValue(PoisonValue::get(CX->getType()),
1690216902
ResultLoad, 0);

llvm/lib/Transforms/Utils/LowerAtomic.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ bool llvm::lowerAtomicCmpXchgInst(AtomicCmpXchgInst *CXI) {
2626
Value *Val = CXI->getNewValOperand();
2727

2828
auto [Orig, Equal] =
29-
buildAtomicCmpXchgValue(Builder, Ptr, Cmp, Val, CXI->getAlign());
29+
buildCmpXchgValue(Builder, Ptr, Cmp, Val, CXI->getAlign());
3030

3131
Value *Res =
3232
Builder.CreateInsertValue(PoisonValue::get(CXI->getType()), Orig, 0);
@@ -37,9 +37,10 @@ bool llvm::lowerAtomicCmpXchgInst(AtomicCmpXchgInst *CXI) {
3737
return true;
3838
}
3939

40-
std::pair<Value *, Value *>
41-
llvm::buildAtomicCmpXchgValue(IRBuilderBase &Builder, Value *Ptr, Value *Cmp,
42-
Value *Val, Align Alignment) {
40+
std::pair<Value *, Value *> llvm::buildCmpXchgValue(IRBuilderBase &Builder,
41+
Value *Ptr, Value *Cmp,
42+
Value *Val,
43+
Align Alignment) {
4344
LoadInst *Orig = Builder.CreateAlignedLoad(Val->getType(), Ptr, Alignment);
4445
Value *Equal = Builder.CreateICmpEQ(Orig, Cmp);
4546
Value *Res = Builder.CreateSelect(Equal, Val, Orig);

0 commit comments

Comments
 (0)