[X86] Add TODO for getTargetConstantFromBasePtr to support non-zero offsets.

RKSimon · RKSimon · commit 2cb97c7e2902 · 2024-04-30T10:43:15.000+01:00
As noted on #66991 - we sometimes share vector constant pool entries, referencing subvectors within them via pointer offsets
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -4639,6 +4639,7 @@ static ConstantPoolSDNode *getTargetConstantPoolFromBasePtr(SDValue Ptr) {
   return dyn_cast<ConstantPoolSDNode>(Ptr);
 }
 
+// TODO: Add support for non-zero offsets.
 static const Constant *getTargetConstantFromBasePtr(SDValue Ptr) {
   ConstantPoolSDNode *CNode = getTargetConstantPoolFromBasePtr(Ptr);
   if (!CNode || CNode->isMachineConstantPoolEntry() || CNode->getOffset() != 0)

Original file line number	Diff line number	Diff line change
`@@ -4639,6 +4639,7 @@ static ConstantPoolSDNode *getTargetConstantPoolFromBasePtr(SDValue Ptr) {`
`4639`	`4639`	`return dyn_cast<ConstantPoolSDNode>(Ptr);`
`4640`	`4640`	`}`
`4641`	`4641`
	`4642`	`+// TODO: Add support for non-zero offsets.`
`4642`	`4643`	`static const Constant *getTargetConstantFromBasePtr(SDValue Ptr) {`
`4643`	`4644`	`ConstantPoolSDNode *CNode = getTargetConstantPoolFromBasePtr(Ptr);`
`4644`	`4645`	`if (!CNode \|\| CNode->isMachineConstantPoolEntry() \|\| CNode->getOffset() != 0)`