Skip to content

Commit 278c0ad

Browse files
authored
[InstCombine] (NFC) Remove improper TODO for a - UMIN (#101076)
It is already handled in a different method, especially as a - UMIN(a, b) cannot be handled by a select statement, unless it means something like: "(c < b) ? b - ((b > c) ? c : b) : 0;" but LLVM handles that case as well.
1 parent 0182334 commit 278c0ad

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -897,7 +897,6 @@ static Instruction *foldSelectZeroOrMul(SelectInst &SI, InstCombinerImpl &IC) {
897897

898898
/// Transform patterns such as (a > b) ? a - b : 0 into usub.sat(a, b).
899899
/// There are 8 commuted/swapped variants of this pattern.
900-
/// TODO: Also support a - UMIN(a,b) patterns.
901900
static Value *canonicalizeSaturatedSubtract(const ICmpInst *ICI,
902901
const Value *TrueVal,
903902
const Value *FalseVal,

0 commit comments

Comments
 (0)