Skip to content

Commit 1f38351

Browse files
ldionnetstellar
authored andcommitted
[libc++] Make benchmarks dry-run by default on the release branch
As reported in #125510, doing a full run of the benchmarks during release testing breaks for some of the testers, and it also takes a long time. The proper fix would be for the release testing process to call `check-cxx` instead of running lit directly inside libc++'s test directory: that will also have the benefit of actually running all of our tests, not only the Lit ones. However, since that fix may take longer to happen, this patch tries to reduce the pain of release testers by dry-running benchmarks by default instead.
1 parent 7b9b674 commit 1f38351

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

libcxx/utils/libcxx/test/params.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ def getSuitableClangTidy(cfg):
371371
name="enable_benchmarks",
372372
choices=["no", "run", "dry-run"],
373373
type=str,
374-
default="run",
374+
default="dry-run",
375375
help="Whether to run the benchmarks in the test suite, to only dry-run them or to disable them entirely.",
376376
actions=lambda mode: [AddFeature(f"enable-benchmarks={mode}")],
377377
),

0 commit comments

Comments
 (0)