Skip to content

Commit 1a87f07

Browse files
authored
[clang] Change initialization of a vector from undef to poison [NFC] (#120446)
It is fully initialized with insertelements.
1 parent c6f753b commit 1a87f07

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

clang/lib/CodeGen/MicrosoftCXXABI.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3454,7 +3454,7 @@ llvm::Value *MicrosoftCXXABI::EmitNonNullMemberPointerConversion(
34543454
if (inheritanceModelHasOnlyOneField(IsFunc, DstInheritance)) {
34553455
Dst = FirstField;
34563456
} else {
3457-
Dst = llvm::UndefValue::get(ConvertMemberPointerType(DstTy));
3457+
Dst = llvm::PoisonValue::get(ConvertMemberPointerType(DstTy));
34583458
unsigned Idx = 0;
34593459
Dst = Builder.CreateInsertValue(Dst, FirstField, Idx++);
34603460
if (inheritanceModelHasNVOffsetField(IsFunc, DstInheritance))

clang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -647,7 +647,7 @@ void (Multiple::*convertB2FuncToMultiple(void (B2::*mp)()))() {
647647
// CHECK: br i1 %{{.*}} label %{{.*}}, label %{{.*}}
648648
//
649649
// memptr.convert: ; preds = %entry
650-
// CHECK: insertvalue { ptr, i32 } undef, ptr %[[mp]], 0
650+
// CHECK: insertvalue { ptr, i32 } poison, ptr %[[mp]], 0
651651
// CHECK: insertvalue { ptr, i32 } %{{.*}}, i32 4, 1
652652
// CHECK: br label
653653
//
@@ -705,7 +705,7 @@ void (D::*convertCToD(void (C::*mp)()))() {
705705
// CHECK: %[[nv_adj:.*]] = select i1 %[[is_nvbase]], i32 %[[nv_disp]], i32 0
706706
// CHECK: %[[dst_adj:.*]] = select i1 %[[is_nvbase]], i32 4, i32 0
707707
// CHECK: %[[adj:.*]] = sub nsw i32 %[[nv_adj]], %[[dst_adj]]
708-
// CHECK: insertvalue { ptr, i32, i32 } undef, ptr {{.*}}, 0
708+
// CHECK: insertvalue { ptr, i32, i32 } poison, ptr {{.*}}, 0
709709
// CHECK: insertvalue { ptr, i32, i32 } {{.*}}, i32 %[[adj]], 1
710710
// CHECK: insertvalue { ptr, i32, i32 } {{.*}}, i32 {{.*}}, 2
711711
// CHECK: br label

0 commit comments

Comments
 (0)