Skip to content

Commit 136f778

Browse files
committed
[Clang] [Python] Fix tests when default config file contains -include
In Gentoo, we make use of Clang's recently-enhanced config file support and add a default include to `clang` invocations using '-include ...'. This breaks clang-python tests like so: ``` ====================================================================== ERROR: test_includes (tests.cindex.test_translation_unit.TestTranslationUnit) ---------------------------------------------------------------------- Traceback (most recent call last): File "/var/tmp/portage/dev-python/clang-python-15.0.6/work/clang/bindings/python/tests/cindex/test_translation_unit.py", line 145, in test_includes eq(i[0], i[1]) File "/var/tmp/portage/dev-python/clang-python-15.0.6/work/clang/bindings/python/tests/cindex/test_translation_unit.py", line 132, in eq self.assert_normpaths_equal(expected[0], actual.source.name) AttributeError: 'NoneType' object has no attribute 'name' ====================================================================== FAIL: test_inclusion_directive (tests.cindex.test_translation_unit.TestTranslationUnit) ---------------------------------------------------------------------- Traceback (most recent call last): File "/var/tmp/portage/dev-python/clang-python-15.0.6/work/clang/bindings/python/tests/cindex/test_translation_unit.py", line 157, in test_inclusion_directive self.assert_normpaths_equal(i[0], i[1]) File "/var/tmp/portage/dev-python/clang-python-15.0.6/work/clang/bindings/python/tests/cindex/test_translation_unit.py", line 126, in assert_normpaths_equal self.assertEqual(os.path.normpath(path1), AssertionError: '/var/tmp/portage/dev-python/clang-python-1[58 chars]r1.h' != '/usr/include/gentoo/fortify.h' - /var/tmp/portage/dev-python/clang-python-15.0.6/work/clang/bindings/python/tests/cindex/INPUTS/header1.h + /usr/include/gentoo/fortify.h ``` Disable using the default Clang configuration files on the system, like we did for other tests. Bug: https://bugs.gentoo.org/890204 Differential Revision: https://reviews.llvm.org/D141248
1 parent 52bcdac commit 136f778

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

clang/bindings/python/tests/CMakeLists.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
# Test target to run Python test suite from main build.
22

3+
# Avoid configurations including '-include' from interfering with
4+
# our tests by setting CLANG_NO_DEFAULT_CONFIG.
35
add_custom_target(check-clang-python
46
COMMAND ${CMAKE_COMMAND} -E env
7+
CLANG_NO_DEFAULT_CONFIG=1
58
CLANG_LIBRARY_PATH=$<TARGET_FILE_DIR:libclang>
69
"${Python3_EXECUTABLE}" -m unittest discover
710
DEPENDS libclang

0 commit comments

Comments
 (0)