[lldb] Improve log message to include missing strings

adrian-prantl · adrian-prantl · commit 0be334848535 · 2024-12-10T09:54:36.000-08:00
diff --git a/lldb/source/DataFormatters/FormatterSection.cpp b/lldb/source/DataFormatters/FormatterSection.cpp
@@ -103,8 +103,9 @@ void LoadTypeSummariesForModule(ModuleSP module_sp) {
         }
         if (type_name.empty() || summary_string.empty()) {
           LLDB_LOG(GetLog(LLDBLog::DataFormatters),
-                   "Missing string(s) in embedded type summary in {0}.",
-                   module_sp->GetFileSpec());
+                   "Missing string(s) in embedded type summary in {0}, "
+                   "type_name={1}, summary={2}",
+                   module_sp->GetFileSpec(), type_name, summary_string);
           return;
         }
         TypeSummaryImpl::Flags flags;

Original file line number	Diff line number	Diff line change
`@@ -103,8 +103,9 @@ void LoadTypeSummariesForModule(ModuleSP module_sp) {`
`103`	`103`	`}`
`104`	`104`	`if (type_name.empty() \|\| summary_string.empty()) {`
`105`	`105`	`LLDB_LOG(GetLog(LLDBLog::DataFormatters),`
`106`		`- "Missing string(s) in embedded type summary in {0}.",`
`107`		`- module_sp->GetFileSpec());`
	`106`	`+ "Missing string(s) in embedded type summary in {0}, "`
	`107`	`+ "type_name={1}, summary={2}",`
	`108`	`+ module_sp->GetFileSpec(), type_name, summary_string);`
`108`	`109`	`return;`
`109`	`110`	`}`
`110`	`111`	`TypeSummaryImpl::Flags flags;`