Address comments

vgvassilev · vgvassilev · commit 0b3fc785ecb7 · 2024-06-03T16:03:44.000Z
diff --git a/clang/lib/CodeGen/ModuleBuilder.cpp b/clang/lib/CodeGen/ModuleBuilder.cpp
@@ -288,7 +288,6 @@ namespace {
     }
 
     void HandleTranslationUnit(ASTContext &Ctx) override {
-      IRGenFinished = true;
 
       // Release the Builder when there is no error.
       if (!Diags.hasUnrecoverableErrorOccurred() && Builder)
@@ -300,8 +299,9 @@ namespace {
         if (Builder)
           Builder->clear();
         M.reset();
-        return;
       }
+
+      IRGenFinished = true;
     }
 
     void AssignInheritanceModel(CXXRecordDecl *RD) override {

Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,6 @@ namespace {`
`288`	`288`	`}`
`289`	`289`
`290`	`290`	`void HandleTranslationUnit(ASTContext &Ctx) override {`
`291`		`- IRGenFinished = true;`
`292`	`291`
`293`	`292`	`// Release the Builder when there is no error.`
`294`	`293`	`if (!Diags.hasUnrecoverableErrorOccurred() && Builder)`
`@@ -300,8 +299,9 @@ namespace {`
`300`	`299`	`if (Builder)`
`301`	`300`	`Builder->clear();`
`302`	`301`	`M.reset();`
`303`		`- return;`
`304`	`302`	`}`
	`303`	`+`
	`304`	`+ IRGenFinished = true;`
`305`	`305`	`}`
`306`	`306`
`307`	`307`	`void AssignInheritanceModel(CXXRecordDecl *RD) override {`