Skip to content

Commit 08ed199

Browse files
committed
[libc] Fix incorrect RPC usage in tests
1 parent ffc5b19 commit 08ed199

File tree

2 files changed

+21
-14
lines changed

2 files changed

+21
-14
lines changed

libc/test/integration/startup/gpu/rpc_interface_test.cpp

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,19 +18,26 @@ using namespace LIBC_NAMESPACE;
1818
static void test_interface(bool end_with_send) {
1919
uint64_t cnt = 0;
2020
rpc::Client::Port port = rpc::client.open<RPC_TEST_INTERFACE>();
21-
port.send([&](rpc::Buffer *buffer) { buffer->data[0] = end_with_send; });
22-
port.send([&](rpc::Buffer *buffer) { buffer->data[0] = cnt = cnt + 1; });
23-
port.recv([&](rpc::Buffer *buffer) { cnt = buffer->data[0]; });
24-
port.send([&](rpc::Buffer *buffer) { buffer->data[0] = cnt = cnt + 1; });
25-
port.recv([&](rpc::Buffer *buffer) { cnt = buffer->data[0]; });
26-
port.send([&](rpc::Buffer *buffer) { buffer->data[0] = cnt = cnt + 1; });
27-
port.send([&](rpc::Buffer *buffer) { buffer->data[0] = cnt = cnt + 1; });
28-
port.recv([&](rpc::Buffer *buffer) { cnt = buffer->data[0]; });
29-
port.recv([&](rpc::Buffer *buffer) { cnt = buffer->data[0]; });
21+
port.send(
22+
[&](rpc::Buffer *buffer, uint32_t) { buffer->data[0] = end_with_send; });
23+
port.send(
24+
[&](rpc::Buffer *buffer, uint32_t) { buffer->data[0] = cnt = cnt + 1; });
25+
port.recv([&](rpc::Buffer *buffer, uint32_t) { cnt = buffer->data[0]; });
26+
port.send(
27+
[&](rpc::Buffer *buffer, uint32_t) { buffer->data[0] = cnt = cnt + 1; });
28+
port.recv([&](rpc::Buffer *buffer, uint32_t) { cnt = buffer->data[0]; });
29+
port.send(
30+
[&](rpc::Buffer *buffer, uint32_t) { buffer->data[0] = cnt = cnt + 1; });
31+
port.send(
32+
[&](rpc::Buffer *buffer, uint32_t) { buffer->data[0] = cnt = cnt + 1; });
33+
port.recv([&](rpc::Buffer *buffer, uint32_t) { cnt = buffer->data[0]; });
34+
port.recv([&](rpc::Buffer *buffer, uint32_t) { cnt = buffer->data[0]; });
3035
if (end_with_send)
31-
port.send([&](rpc::Buffer *buffer) { buffer->data[0] = cnt = cnt + 1; });
36+
port.send([&](rpc::Buffer *buffer, uint32_t) {
37+
buffer->data[0] = cnt = cnt + 1;
38+
});
3239
else
33-
port.recv([&](rpc::Buffer *buffer) { cnt = buffer->data[0]; });
40+
port.recv([&](rpc::Buffer *buffer, uint32_t) { cnt = buffer->data[0]; });
3441
port.close();
3542

3643
ASSERT_TRUE(cnt == 9 && "Invalid number of increments");

libc/test/integration/startup/gpu/rpc_test.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ static void test_add_simple() {
2020
for (uint32_t i = 0; i < num_additions; ++i) {
2121
rpc::Client::Port port = rpc::client.open<RPC_TEST_INCREMENT>();
2222
port.send_and_recv(
23-
[=](rpc::Buffer *buffer) {
23+
[=](rpc::Buffer *buffer, uint32_t) {
2424
reinterpret_cast<uint64_t *>(buffer->data)[0] = cnt;
2525
},
26-
[&](rpc::Buffer *buffer) {
26+
[&](rpc::Buffer *buffer, uint32_t) {
2727
cnt = reinterpret_cast<uint64_t *>(buffer->data)[0];
2828
});
2929
port.close();
@@ -34,7 +34,7 @@ static void test_add_simple() {
3434
// Test to ensure that the RPC mechanism doesn't hang on divergence.
3535
static void test_noop(uint8_t data) {
3636
rpc::Client::Port port = rpc::client.open<RPC_NOOP>();
37-
port.send([=](rpc::Buffer *buffer) { buffer->data[0] = data; });
37+
port.send([=](rpc::Buffer *buffer, uint32_t) { buffer->data[0] = data; });
3838
port.close();
3939
}
4040

0 commit comments

Comments
 (0)