Skip to content

Commit 054b5fc

Browse files
authored
X86: add some missing lowerings for shuffles on bf16 element type. (#76076)
Some shuffles with `bf16` as element type were running into a `llvm_unreachable`. Key to reproducing was to chain two shuffles. ```llvm define <2 x bfloat> @shuffle_chained_v32bf16_v2bf16(<32 x bfloat> %a) { %s = shufflevector <32 x bfloat> %a, <32 x bfloat> zeroinitializer, <32 x i32> <i32 0, i32 16, i32 1, i32 17, i32 2, i32 18, i32 3, i32 19, i32 4, i32 20, i32 5, i32 21, i32 6, i32 22, i32 7, i32 23, i32 8, i32 24, i32 9, i32 25, i32 10, i32 26, i32 11, i32 27, i32 12, i32 28, i32 13, i32 29, i32 14, i32 30, i32 15, i32 31> %s2 = shufflevector <32 x bfloat> %s, <32 x bfloat> zeroinitializer, <2 x i32> <i32 0, i32 1> ret <2 x bfloat> %s2 } ``` This was hitting this UNREACHABLE: ``` Not a valid 512-bit x86 vector type! UNREACHABLE executed at /home/benoit/iree/third_party/llvm-project/llvm/lib/Target/X86/X86ISelLowering.cpp:17124! PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace. Stack dump: 0. Program arguments: /home/benoit/mlir-build/bin/llc -mtriple=x86_64-unknown-linux-gnu -mattr=+avx512f,+avx512vl,+avx512bw,+avx512bf16 1. Running pass 'Function Pass Manager' on module '<stdin>'. 2. Running pass 'X86 DAG->DAG Instruction Selection' on function '@shuffle_chained_v32bf16_v2bf16' ```
1 parent f5fd183 commit 054b5fc

File tree

2 files changed

+72
-2
lines changed

2 files changed

+72
-2
lines changed

llvm/lib/Target/X86/X86ISelLowering.cpp

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14369,6 +14369,13 @@ static SDValue lower128BitShuffle(const SDLoc &DL, ArrayRef<int> Mask,
1436914369
const APInt &Zeroable,
1437014370
const X86Subtarget &Subtarget,
1437114371
SelectionDAG &DAG) {
14372+
if (VT == MVT::v8bf16) {
14373+
V1 = DAG.getBitcast(MVT::v8i16, V1);
14374+
V2 = DAG.getBitcast(MVT::v8i16, V2);
14375+
return DAG.getBitcast(VT,
14376+
DAG.getVectorShuffle(MVT::v8i16, DL, V1, V2, Mask));
14377+
}
14378+
1437214379
switch (VT.SimpleTy) {
1437314380
case MVT::v2i64:
1437414381
return lowerV2I64Shuffle(DL, Mask, Zeroable, V1, V2, Subtarget, DAG);
@@ -17096,14 +17103,14 @@ static SDValue lower512BitShuffle(const SDLoc &DL, ArrayRef<int> Mask,
1709617103
return splitAndLowerShuffle(DL, VT, V1, V2, Mask, DAG, /*SimpleOnly*/ false);
1709717104
}
1709817105

17099-
if (VT == MVT::v32f16) {
17106+
if (VT == MVT::v32f16 || VT == MVT::v32bf16) {
1710017107
if (!Subtarget.hasBWI())
1710117108
return splitAndLowerShuffle(DL, VT, V1, V2, Mask, DAG,
1710217109
/*SimpleOnly*/ false);
1710317110

1710417111
V1 = DAG.getBitcast(MVT::v32i16, V1);
1710517112
V2 = DAG.getBitcast(MVT::v32i16, V2);
17106-
return DAG.getBitcast(MVT::v32f16,
17113+
return DAG.getBitcast(VT,
1710717114
DAG.getVectorShuffle(MVT::v32i16, DL, V1, V2, Mask));
1710817115
}
1710917116

Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4
2+
; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnu -mattr=+avx512f,+avx512vl,+avx512bw,+avx512bf16 | FileCheck %s
3+
4+
target triple = "x86_64-unknown-linux-gnu"
5+
6+
define <2 x bfloat> @shuffle_chained_v32bf16_v2bf16(<32 x bfloat> %a) {
7+
; CHECK-LABEL: shuffle_chained_v32bf16_v2bf16:
8+
; CHECK: # %bb.0:
9+
; CHECK-NEXT: pushq %rbp
10+
; CHECK-NEXT: .cfi_def_cfa_offset 16
11+
; CHECK-NEXT: .cfi_offset %rbp, -16
12+
; CHECK-NEXT: movq %rsp, %rbp
13+
; CHECK-NEXT: .cfi_def_cfa_register %rbp
14+
; CHECK-NEXT: andq $-64, %rsp
15+
; CHECK-NEXT: subq $128, %rsp
16+
; CHECK-NEXT: vpbroadcastd {{.*#+}} xmm1 = [0,16,0,16,0,16,0,16]
17+
; CHECK-NEXT: vpermw %zmm0, %zmm1, %zmm0
18+
; CHECK-NEXT: vmovdqa64 %zmm0, (%rsp)
19+
; CHECK-NEXT: vmovaps (%rsp), %xmm0
20+
; CHECK-NEXT: movq %rbp, %rsp
21+
; CHECK-NEXT: popq %rbp
22+
; CHECK-NEXT: .cfi_def_cfa %rsp, 8
23+
; CHECK-NEXT: vzeroupper
24+
; CHECK-NEXT: retq
25+
%s = shufflevector <32 x bfloat> %a, <32 x bfloat> zeroinitializer, <32 x i32> <i32 0, i32 16, i32 1, i32 17, i32 2, i32 18, i32 3, i32 19, i32 4, i32 20, i32 5, i32 21, i32 6, i32 22, i32 7, i32 23, i32 8, i32 24, i32 9, i32 25, i32 10, i32 26, i32 11, i32 27, i32 12, i32 28, i32 13, i32 29, i32 14, i32 30, i32 15, i32 31>
26+
%s2 = shufflevector <32 x bfloat> %s, <32 x bfloat> zeroinitializer, <2 x i32> <i32 0, i32 1>
27+
ret <2 x bfloat> %s2
28+
}
29+
30+
define <2 x bfloat> @shuffle_chained_v16bf16(<16 x bfloat> %a) {
31+
; CHECK-LABEL: shuffle_chained_v16bf16:
32+
; CHECK: # %bb.0:
33+
; CHECK-NEXT: pushq %rbp
34+
; CHECK-NEXT: .cfi_def_cfa_offset 16
35+
; CHECK-NEXT: .cfi_offset %rbp, -16
36+
; CHECK-NEXT: movq %rsp, %rbp
37+
; CHECK-NEXT: .cfi_def_cfa_register %rbp
38+
; CHECK-NEXT: andq $-32, %rsp
39+
; CHECK-NEXT: subq $96, %rsp
40+
; CHECK-NEXT: vmovaps %ymm0, (%rsp)
41+
; CHECK-NEXT: vmovdqa (%rsp), %xmm0
42+
; CHECK-NEXT: vpunpcklwd {{.*#+}} xmm0 = xmm0[0],mem[0],xmm0[1],mem[1],xmm0[2],mem[2],xmm0[3],mem[3]
43+
; CHECK-NEXT: vmovdqa %ymm0, {{[0-9]+}}(%rsp)
44+
; CHECK-NEXT: vmovaps {{[0-9]+}}(%rsp), %xmm0
45+
; CHECK-NEXT: movq %rbp, %rsp
46+
; CHECK-NEXT: popq %rbp
47+
; CHECK-NEXT: .cfi_def_cfa %rsp, 8
48+
; CHECK-NEXT: vzeroupper
49+
; CHECK-NEXT: retq
50+
%s = shufflevector <16 x bfloat> %a, <16 x bfloat> zeroinitializer, <16 x i32> <i32 0, i32 8, i32 1, i32 9, i32 2, i32 10, i32 3, i32 11, i32 4, i32 12, i32 5, i32 13, i32 6, i32 14, i32 7, i32 15>
51+
%s2 = shufflevector <16 x bfloat> %s, <16 x bfloat> zeroinitializer, <2 x i32> <i32 0, i32 1>
52+
ret <2 x bfloat> %s2
53+
}
54+
55+
define <2 x bfloat> @shuffle_chained_v8bf16(<8 x bfloat> %a) {
56+
; CHECK-LABEL: shuffle_chained_v8bf16:
57+
; CHECK: # %bb.0:
58+
; CHECK-NEXT: vpshufb {{.*#+}} xmm0 = xmm0[0,1,8,9,2,3,10,11,4,5,12,13,6,7,14,15]
59+
; CHECK-NEXT: retq
60+
%s = shufflevector <8 x bfloat> %a, <8 x bfloat> zeroinitializer, <8 x i32> <i32 0, i32 4, i32 1, i32 5, i32 2, i32 6, i32 3, i32 7>
61+
%s2 = shufflevector <8 x bfloat> %s, <8 x bfloat> zeroinitializer, <2 x i32> <i32 0, i32 1>
62+
ret <2 x bfloat> %s2
63+
}

0 commit comments

Comments
 (0)