Skip to content

Conversation

@wizardengineer
Copy link
Contributor

@wizardengineer wizardengineer commented Aug 25, 2025

  1. Catch Entry Parsing: parseCatchEntry in CIRDialect.cpp now properly handles #cir.unwind attributes

  2. Resume Operation: Fix record definition of cir.resume in order to handle locations correctly

Issue:

  • error: expected '{' to begin a region when parsing catch [#cir.unwind {
  • error: undefined symbol alias id when parsing cir.resume loc(#loc)

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for your first contribution! LGTM

@wizardengineer wizardengineer deleted the julius/catch-parse branch August 26, 2025 05:43
@wizardengineer wizardengineer restored the julius/catch-parse branch August 26, 2025 05:43
@wizardengineer
Copy link
Contributor Author

Ignore the close message, I had accidentally closed it

@bcardosolopes
Copy link
Member

Will merge as soon as the tests pass!

@wizardengineer
Copy link
Contributor Author

Will merge as soon as the tests pass!

@bcardosolopes there's a Clang CIR Tests / Test clang-cir / Lit Tests (windows-2019) that fail, is it a false positive?

It says it got cancelled, not too sure why.

Also, thanks for taking your time to review this Bruno 😄

@bcardosolopes bcardosolopes merged commit 5e0487a into llvm:main Aug 26, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants