From 2940d567d0cbc8673a3b3365e76d8e31b8210e5d Mon Sep 17 00:00:00 2001
From: Ayokunle Amodu <121697771+ayokunle321@users.noreply.github.com>
Date: Tue, 25 Mar 2025 13:21:02 -0600
Subject: [PATCH] add mlir lowering for acos op

---
 .../Lowering/ThroughMLIR/LowerCIRToMLIR.cpp   | 45 ++++++++++++-------
 clang/test/CIR/Lowering/ThroughMLIR/acos.cir  | 30 +++++++++++++
 2 files changed, 59 insertions(+), 16 deletions(-)
 create mode 100644 clang/test/CIR/Lowering/ThroughMLIR/acos.cir

diff --git a/clang/lib/CIR/Lowering/ThroughMLIR/LowerCIRToMLIR.cpp b/clang/lib/CIR/Lowering/ThroughMLIR/LowerCIRToMLIR.cpp
index a9aef3663678..210558c40699 100644
--- a/clang/lib/CIR/Lowering/ThroughMLIR/LowerCIRToMLIR.cpp
+++ b/clang/lib/CIR/Lowering/ThroughMLIR/LowerCIRToMLIR.cpp
@@ -279,6 +279,18 @@ class CIRStoreOpLowering : public mlir::OpConversionPattern<cir::StoreOp> {
   }
 };
 
+class CIRACosOpLowering : public mlir::OpConversionPattern<cir::ACosOp> {
+public:
+  using OpConversionPattern<cir::ACosOp>::OpConversionPattern;
+
+  mlir::LogicalResult
+  matchAndRewrite(cir::ACosOp op, OpAdaptor adaptor,
+                  mlir::ConversionPatternRewriter &rewriter) const override {
+    rewriter.replaceOpWithNewOp<mlir::math::AcosOp>(op, adaptor.getSrc());
+    return mlir::LogicalResult::success();
+  }
+};
+
 class CIRCosOpLowering : public mlir::OpConversionPattern<cir::CosOp> {
 public:
   using OpConversionPattern<cir::CosOp>::OpConversionPattern;
@@ -1356,22 +1368,23 @@ void populateCIRToMLIRConversionPatterns(mlir::RewritePatternSet &patterns,
                                          mlir::TypeConverter &converter) {
   patterns.add<CIRReturnLowering, CIRBrOpLowering>(patterns.getContext());
 
-  patterns.add<
-      CIRCmpOpLowering, CIRCallOpLowering, CIRUnaryOpLowering, CIRBinOpLowering,
-      CIRLoadOpLowering, CIRConstantOpLowering, CIRStoreOpLowering,
-      CIRAllocaOpLowering, CIRFuncOpLowering, CIRScopeOpLowering,
-      CIRBrCondOpLowering, CIRTernaryOpLowering, CIRYieldOpLowering,
-      CIRCosOpLowering, CIRGlobalOpLowering, CIRGetGlobalOpLowering,
-      CIRCastOpLowering, CIRPtrStrideOpLowering, CIRSqrtOpLowering,
-      CIRCeilOpLowering, CIRExp2OpLowering, CIRExpOpLowering, CIRFAbsOpLowering,
-      CIRAbsOpLowering, CIRFloorOpLowering, CIRLog10OpLowering,
-      CIRLog2OpLowering, CIRLogOpLowering, CIRRoundOpLowering,
-      CIRPtrStrideOpLowering, CIRSinOpLowering, CIRShiftOpLowering,
-      CIRBitClzOpLowering, CIRBitCtzOpLowering, CIRBitPopcountOpLowering,
-      CIRBitClrsbOpLowering, CIRBitFfsOpLowering, CIRBitParityOpLowering,
-      CIRIfOpLowering, CIRVectorCreateLowering, CIRVectorInsertLowering,
-      CIRVectorExtractLowering, CIRVectorCmpOpLowering>(converter,
-                                                        patterns.getContext());
+  patterns
+      .add<CIRCmpOpLowering, CIRCallOpLowering, CIRUnaryOpLowering,
+           CIRBinOpLowering, CIRLoadOpLowering, CIRConstantOpLowering,
+           CIRStoreOpLowering, CIRAllocaOpLowering, CIRFuncOpLowering,
+           CIRScopeOpLowering, CIRBrCondOpLowering, CIRTernaryOpLowering,
+           CIRYieldOpLowering, CIRCosOpLowering, CIRGlobalOpLowering,
+           CIRGetGlobalOpLowering, CIRCastOpLowering, CIRPtrStrideOpLowering,
+           CIRSqrtOpLowering, CIRCeilOpLowering, CIRACosOpLowering,
+           CIRExp2OpLowering, CIRExpOpLowering, CIRFAbsOpLowering,
+           CIRAbsOpLowering, CIRFloorOpLowering, CIRLog10OpLowering,
+           CIRLog2OpLowering, CIRLogOpLowering, CIRRoundOpLowering,
+           CIRPtrStrideOpLowering, CIRSinOpLowering, CIRShiftOpLowering,
+           CIRBitClzOpLowering, CIRBitCtzOpLowering, CIRBitPopcountOpLowering,
+           CIRBitClrsbOpLowering, CIRBitFfsOpLowering, CIRBitParityOpLowering,
+           CIRIfOpLowering, CIRVectorCreateLowering, CIRVectorInsertLowering,
+           CIRVectorExtractLowering, CIRVectorCmpOpLowering>(
+          converter, patterns.getContext());
 }
 
 static mlir::TypeConverter prepareTypeConverter() {
diff --git a/clang/test/CIR/Lowering/ThroughMLIR/acos.cir b/clang/test/CIR/Lowering/ThroughMLIR/acos.cir
new file mode 100644
index 000000000000..f885c7adea7d
--- /dev/null
+++ b/clang/test/CIR/Lowering/ThroughMLIR/acos.cir
@@ -0,0 +1,30 @@
+// RUN: cir-opt %s -cir-to-mlir -o %t.mlir
+// RUN: FileCheck %s --input-file %t.mlir
+
+module {
+  cir.func @foo() {
+    %0 = cir.const #cir.fp<1.0> : !cir.float
+    %1 = cir.const #cir.fp<3.0> : !cir.long_double<!cir.f80>
+    %2 = cir.const #cir.fp<2.0> : !cir.double
+    %3 = cir.const #cir.fp<4.00> : !cir.long_double<!cir.double>
+    %4 = cir.acos %0 : !cir.float
+    %5 = cir.acos %1 : !cir.long_double<!cir.f80>
+    %6 = cir.acos %2 : !cir.double
+    %7 = cir.acos %3 : !cir.long_double<!cir.double>
+    cir.return
+  }
+}
+
+// CHECK:      module {
+// CHECK-NEXT:   func.func @foo() {
+// CHECK-NEXT:     %[[C0:.+]] = arith.constant 1.000000e+00 : f32
+// CHECK-NEXT:     %[[C1:.+]] = arith.constant 3.000000e+00 : f80
+// CHECK-NEXT:     %[[C2:.+]] = arith.constant 2.000000e+00 : f64
+// CHECK-NEXT:     %[[C3:.+]] = arith.constant 4.000000e+00 : f64
+// CHECK-NEXT:     %{{.+}} = math.acos %[[C0]] : f32
+// CHECK-NEXT:     %{{.+}} = math.acos %[[C1]] : f80
+// CHECK-NEXT:     %{{.+}} = math.acos %[[C2]] : f64
+// CHECK-NEXT:     %{{.+}} = math.acos %[[C3]] : f64
+// CHECK-NEXT:     return
+// CHECK-NEXT:   }
+// CHECK-NEXT: }