Skip to content

Commit b81d588

Browse files
JDevlieghereAlexisPerry
authored andcommitted
[lldb] Remove LLVM_PRETTY_FUNCTION from LLDB_SCOPED_TIMERF
The macro already uses LLVM_PRETTY_FUNCTION as the timer category, so there's no point in duplicating it in the timer message.
1 parent 925a1c8 commit b81d588

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,7 @@ void DWARFDebugAranges::AppendRange(dw_offset_t offset, dw_addr_t low_pc,
8989
}
9090

9191
void DWARFDebugAranges::Sort(bool minimize) {
92-
LLDB_SCOPED_TIMERF("%s this = %p", LLVM_PRETTY_FUNCTION,
93-
static_cast<void *>(this));
92+
LLDB_SCOPED_TIMER();
9493

9594
m_aranges.Sort();
9695
m_aranges.CombineConsecutiveEntriesWithEqualData();

lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -710,8 +710,8 @@ llvm::DWARFDebugAbbrev *SymbolFileDWARF::DebugAbbrev() {
710710

711711
DWARFDebugInfo &SymbolFileDWARF::DebugInfo() {
712712
llvm::call_once(m_info_once_flag, [&] {
713-
LLDB_SCOPED_TIMERF("%s this = %p", LLVM_PRETTY_FUNCTION,
714-
static_cast<void *>(this));
713+
LLDB_SCOPED_TIMER();
714+
715715
m_info = std::make_unique<DWARFDebugInfo>(*this, m_context);
716716
});
717717
return *m_info;
@@ -732,8 +732,7 @@ DWARFCompileUnit *SymbolFileDWARF::GetDWARFCompileUnit(CompileUnit *comp_unit) {
732732

733733
DWARFDebugRanges *SymbolFileDWARF::GetDebugRanges() {
734734
if (!m_ranges) {
735-
LLDB_SCOPED_TIMERF("%s this = %p", LLVM_PRETTY_FUNCTION,
736-
static_cast<void *>(this));
735+
LLDB_SCOPED_TIMER();
737736

738737
if (m_context.getOrLoadRangesData().GetByteSize() > 0)
739738
m_ranges = std::make_unique<DWARFDebugRanges>();

lldb/source/Symbol/DWARFCallFrameInfo.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -423,8 +423,7 @@ void DWARFCallFrameInfo::GetFDEIndex() {
423423
if (m_fde_index_initialized) // if two threads hit the locker
424424
return;
425425

426-
LLDB_SCOPED_TIMERF("%s - %s", LLVM_PRETTY_FUNCTION,
427-
m_objfile.GetFileSpec().GetFilename().AsCString(""));
426+
LLDB_SCOPED_TIMERF("%s", m_objfile.GetFileSpec().GetFilename().AsCString(""));
428427

429428
bool clear_address_zeroth_bit = false;
430429
if (ArchSpec arch = m_objfile.GetArchitecture()) {

0 commit comments

Comments
 (0)