Skip to content

Commit df6a69b

Browse files
spikehkuba-moo
authored andcommitted
io_uring/zcrx: selftests: fix setting ntuple rule into rss
Fix ethtool syntax for setting ntuple rule into rss. It should be `context' instead of `action'. Signed-off-by: David Wei <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 075001c commit df6a69b

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

tools/testing/selftests/drivers/net/hw/iou-zcrx.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ def _get_combined_channels(cfg):
1919
return int(values[1])
2020

2121

22-
def _create_rss_ctx(cfg, chans):
23-
output = ethtool(f"-X {cfg.ifname} context new start {chans - 1} equal 1", host=cfg.remote).stdout
22+
def _create_rss_ctx(cfg, chan):
23+
output = ethtool(f"-X {cfg.ifname} context new start {chan} equal 1", host=cfg.remote).stdout
2424
values = re.search(r'New RSS context is (\d+)', output).group(1)
2525
ctx_id = int(values)
2626
return (ctx_id, defer(ethtool, f"-X {cfg.ifname} delete context {ctx_id}", host=cfg.remote))
@@ -32,8 +32,8 @@ def _set_flow_rule(cfg, port, chan):
3232
return int(values)
3333

3434

35-
def _set_flow_rule_rss(cfg, port, chan):
36-
output = ethtool(f"-N {cfg.ifname} flow-type tcp6 dst-port {port} action {chan}", host=cfg.remote).stdout
35+
def _set_flow_rule_rss(cfg, port, ctx_id):
36+
output = ethtool(f"-N {cfg.ifname} flow-type tcp6 dst-port {port} context {ctx_id}", host=cfg.remote).stdout
3737
values = re.search(r'ID (\d+)', output).group(1)
3838
return int(values)
3939

@@ -121,7 +121,7 @@ def test_zcrx_rss(cfg) -> None:
121121
ethtool(f"-X {cfg.ifname} equal {combined_chans - 1}", host=cfg.remote)
122122
defer(ethtool, f"-X {cfg.ifname} default", host=cfg.remote)
123123

124-
(ctx_id, delete_ctx) = _create_rss_ctx(cfg, combined_chans)
124+
(ctx_id, delete_ctx) = _create_rss_ctx(cfg, combined_chans - 1)
125125
flow_rule_id = _set_flow_rule_rss(cfg, port, ctx_id)
126126
defer(ethtool, f"-N {cfg.ifname} delete {flow_rule_id}", host=cfg.remote)
127127

0 commit comments

Comments
 (0)