Skip to content

Commit ba5f785

Browse files
Furong Xukuba-moo
Furong Xu
authored andcommitted
net: stmmac: Drop redundant skb_mark_for_recycle() for SKB frags
After commit df542f6 ("net: stmmac: Switch to zero-copy in non-XDP RX path"), SKBs are always marked for recycle, it is redundant to mark SKBs more than once when new frags are appended. Signed-off-by: Furong Xu <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent f6f2e94 commit ba5f785

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5644,9 +5644,6 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue)
56445644
skb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags,
56455645
buf->page, buf->page_offset, buf1_len,
56465646
priv->dma_conf.dma_buf_sz);
5647-
5648-
/* Data payload appended into SKB */
5649-
skb_mark_for_recycle(skb);
56505647
buf->page = NULL;
56515648
}
56525649

@@ -5656,9 +5653,6 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue)
56565653
skb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags,
56575654
buf->sec_page, 0, buf2_len,
56585655
priv->dma_conf.dma_buf_sz);
5659-
5660-
/* Data payload appended into SKB */
5661-
skb_mark_for_recycle(skb);
56625656
buf->sec_page = NULL;
56635657
}
56645658

0 commit comments

Comments
 (0)