Skip to content

Commit b182fbb

Browse files
kuba-mooNipaLocal
authored and
NipaLocal
committed
netlink: specs: ovs_vport: align with C codegen capabilities
We started generating C code for OvS a while back, but actually C codegen only supports fixed headers specified at the family level right now (schema also allows specifying them per op). ovs_flow and ovs_datapath already specify the fixed header at the family level but ovs_vport does it per op. Move the property, all ops use the same header. This ensures YNL C sees the correct hdr_len: const struct ynl_family ynl_ovs_vport_family = { .name = "ovs_vport", - .hdr_len = sizeof(struct genlmsghdr), + .hdr_len = sizeof(struct genlmsghdr) + sizeof(struct ovs_header), }; Fixes: 7c59c9c ("tools: ynl: generate code for ovs families") Signed-off-by: Jakub Kicinski <[email protected]> Signed-off-by: NipaLocal <nipa@local>
1 parent c0f04a2 commit b182fbb

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

Documentation/netlink/specs/ovs_vport.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,12 +123,12 @@ attribute-sets:
123123

124124
operations:
125125
name-prefix: ovs-vport-cmd-
126+
fixed-header: ovs-header
126127
list:
127128
-
128129
name: new
129130
doc: Create a new OVS vport
130131
attribute-set: vport
131-
fixed-header: ovs-header
132132
do:
133133
request:
134134
attributes:
@@ -141,7 +141,6 @@ operations:
141141
name: del
142142
doc: Delete existing OVS vport from a data path
143143
attribute-set: vport
144-
fixed-header: ovs-header
145144
do:
146145
request:
147146
attributes:
@@ -152,7 +151,6 @@ operations:
152151
name: get
153152
doc: Get / dump OVS vport configuration and state
154153
attribute-set: vport
155-
fixed-header: ovs-header
156154
do: &vport-get-op
157155
request:
158156
attributes:

0 commit comments

Comments
 (0)