Skip to content

Commit 8cf8bf0

Browse files
TropicaoNipaLocal
authored and
NipaLocal
committed
net: stmmac: add explicit check and error on invalid PTP clock rate
While some platforms implementing dwmac open-code the clk_ptp_rate value, some others dynamically retrieve the value at runtime. If the retrieved value happens to be 0 for any reason, it will eventually propagate up to PTP initialization when bringing up the interface, leading to a divide by 0: Division by zero in kernel. CPU: 1 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.12.30-00001-g48313bd5768a kernel-patches#22 Hardware name: STM32 (Device Tree Support) Call trace: unwind_backtrace from show_stack+0x18/0x1c show_stack from dump_stack_lvl+0x6c/0x8c dump_stack_lvl from Ldiv0_64+0x8/0x18 Ldiv0_64 from stmmac_init_tstamp_counter+0x190/0x1a4 stmmac_init_tstamp_counter from stmmac_hw_setup+0xc1c/0x111c stmmac_hw_setup from __stmmac_open+0x18c/0x434 __stmmac_open from stmmac_open+0x3c/0xbc stmmac_open from __dev_open+0xf4/0x1ac __dev_open from __dev_change_flags+0x1cc/0x224 __dev_change_flags from dev_change_flags+0x24/0x60 dev_change_flags from ip_auto_config+0x2e8/0x11a0 ip_auto_config from do_one_initcall+0x84/0x33c do_one_initcall from kernel_init_freeable+0x1b8/0x214 kernel_init_freeable from kernel_init+0x24/0x140 kernel_init from ret_from_fork+0x14/0x28 Exception stack(0xe0815fb0 to 0xe0815ff8) Prevent this division by 0 by adding an explicit check and error log about the actual issue. Signed-off-by: Alexis Lothoré <[email protected]> Signed-off-by: NipaLocal <nipa@local>
1 parent 724d7a1 commit 8cf8bf0

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -805,6 +805,11 @@ int stmmac_init_tstamp_counter(struct stmmac_priv *priv, u32 systime_flags)
805805
if (!(priv->dma_cap.time_stamp || priv->dma_cap.atime_stamp))
806806
return -EOPNOTSUPP;
807807

808+
if (!priv->plat->clk_ptp_rate) {
809+
netdev_err(priv->dev, "Invalid PTP clock rate");
810+
return -EINVAL;
811+
}
812+
808813
stmmac_config_hw_tstamping(priv, priv->ptpaddr, systime_flags);
809814
priv->systime_flags = systime_flags;
810815

0 commit comments

Comments
 (0)