Skip to content

Commit 8cf699e

Browse files
Eric Dumazetdavem330
Eric Dumazet
authored andcommitted
mlx4: do not call napi_schedule() without care
Disable BH around the call to napi_schedule() to avoid following warning [ 52.095499] NOHZ: local_softirq_pending 08 [ 52.421291] NOHZ: local_softirq_pending 08 [ 52.608313] NOHZ: local_softirq_pending 08 Fixes: 8d59de8 ("net/mlx4_en: Process all completions in RX rings after port goes up") Signed-off-by: Eric Dumazet <[email protected]> Cc: Erez Shitrit <[email protected]> Cc: Eugenia Emantayev <[email protected]> Cc: Tariq Toukan <[email protected]> Acked-by: Tariq Toukan <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 5071919 commit 8cf699e

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/net/ethernet/mellanox/mlx4/en_netdev.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1748,8 +1748,11 @@ int mlx4_en_start_port(struct net_device *dev)
17481748
/* Process all completions if exist to prevent
17491749
* the queues freezing if they are full
17501750
*/
1751-
for (i = 0; i < priv->rx_ring_num; i++)
1751+
for (i = 0; i < priv->rx_ring_num; i++) {
1752+
local_bh_disable();
17521753
napi_schedule(&priv->rx_cq[i]->napi);
1754+
local_bh_enable();
1755+
}
17531756

17541757
netif_tx_start_all_queues(dev);
17551758
netif_device_attach(dev);

0 commit comments

Comments
 (0)