Skip to content

Commit 491deb9

Browse files
Pengtao Hekuba-moo
Pengtao He
authored andcommitted
net/tls: fix kernel panic when alloc_page failed
We cannot set frag_list to NULL pointer when alloc_page failed. It will be used in tls_strp_check_queue_ok when the next time tls_strp_read_sock is called. This is because we don't reset full_len in tls_strp_flush_anchor_copy() so the recv path will try to continue handling the partial record on the next call but we dettached the rcvq from the frag list. Alternative fix would be to reset full_len. Unable to handle kernel NULL pointer dereference at virtual address 0000000000000028 Call trace: tls_strp_check_rcv+0x128/0x27c tls_strp_data_ready+0x34/0x44 tls_data_ready+0x3c/0x1f0 tcp_data_ready+0x9c/0xe4 tcp_data_queue+0xf6c/0x12d0 tcp_rcv_established+0x52c/0x798 Fixes: 84c61fe ("tls: rx: do not use the standard strparser") Signed-off-by: Pengtao He <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 3933536 commit 491deb9

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

net/tls/tls_strp.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,6 @@ static int tls_strp_read_copy(struct tls_strparser *strp, bool qshort)
396396
return 0;
397397

398398
shinfo = skb_shinfo(strp->anchor);
399-
shinfo->frag_list = NULL;
400399

401400
/* If we don't know the length go max plus page for cipher overhead */
402401
need_spc = strp->stm.full_len ?: TLS_MAX_PAYLOAD_SIZE + PAGE_SIZE;
@@ -412,6 +411,8 @@ static int tls_strp_read_copy(struct tls_strparser *strp, bool qshort)
412411
page, 0, 0);
413412
}
414413

414+
shinfo->frag_list = NULL;
415+
415416
strp->copy_mode = 1;
416417
strp->stm.offset = 0;
417418

0 commit comments

Comments
 (0)