Skip to content

Commit 2c74d05

Browse files
kmaincentNipaLocal
authored and
NipaLocal
committed
netlink: specs: ethtool: Remove UAPI duplication of phy-upstream enum
The phy-upstream enum is already defined in the ethtool.h UAPI header and used by the ethtool userspace tool. However, the ethtool spec does not reference it, causing YNL to auto-generate a duplicate and redundant enum. Fix this by updating the spec to reference the existing UAPI enum in ethtool.h. Signed-off-by: Kory Maincent <[email protected]> Signed-off-by: NipaLocal <nipa@local>
1 parent 26b8750 commit 2c74d05

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

Documentation/netlink/specs/ethtool.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,10 @@ definitions:
8989
doc: Group of short_detected states
9090
-
9191
name: phy-upstream-type
92-
enum-name:
92+
enum-name: phy-upstream
93+
header: linux/ethtool.h
9394
type: enum
95+
name-prefix: phy-upstream
9496
entries: [ mac, phy ]
9597
-
9698
name: tcp-data-split

include/uapi/linux/ethtool_netlink_generated.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,6 @@ enum ethtool_header_flags {
3131
ETHTOOL_FLAG_STATS = 4,
3232
};
3333

34-
enum {
35-
ETHTOOL_PHY_UPSTREAM_TYPE_MAC,
36-
ETHTOOL_PHY_UPSTREAM_TYPE_PHY,
37-
};
38-
3934
enum ethtool_tcp_data_split {
4035
ETHTOOL_TCP_DATA_SPLIT_UNKNOWN,
4136
ETHTOOL_TCP_DATA_SPLIT_DISABLED,

0 commit comments

Comments
 (0)