Make tests and schema in line with query auth errors

Author: max-svistunov

docs/openapi.json

@@ -355,7 +355,7 @@
                             }
                         ]
                     },
-                    "400": {
+                    "401": {
                         "description": "Missing or invalid credentials provided by client",
                         "content": {
                             "application/json": {
@@ -375,6 +375,9 @@
                             }
                         }
                     },
+                    "404": {
+                        "description": "Requested model or provider not found"
+                    },
                     "429": {
                         "description": "The quota has been exceeded",
                         "content": {
@@ -690,6 +693,16 @@
                             }
                         }
                     },
+                    "400": {
+                        "description": "Missing or invalid credentials provided by client",
+                        "content": {
+                            "application/json": {
+                                "schema": {
+                                    "$ref": "#/components/schemas/UnauthorizedResponse"
+                                }
+                            }
+                        }
+                    },
                     "401": {
                         "description": "Missing or invalid credentials provided by client",
                         "content": {
@@ -1267,7 +1280,7 @@
                         }
                     },
                     "403": {
-                        "description": "Client does not have permission to access conversation",
+                        "description": "User is not authorized",
                         "content": {
                             "application/json": {
                                 "schema": {
@@ -4240,4 +4253,4 @@
             }
         }
     }
-}
+}

src/app/endpoints/query.py

@@ -491,7 +491,7 @@ def select_model_and_provider_id(
     """
     # If no models are available, raise an exception
     if not models:
-        message = "No LLM model found in available models"
+        message = "No models available"
         logger.error(message)
         raise HTTPException(
             status_code=status.HTTP_404_NOT_FOUND,
@@ -530,7 +530,7 @@ def select_model_and_provider_id(
             model_label = model_id.split("/", 1)[1] if "/" in model_id else model_id
             return model_id, model_label, provider_id
         except (StopIteration, AttributeError) as e:
-            message = "No LLM model found in available models"
+            message = "No models available"
             logger.error(message)
             raise HTTPException(
                 status_code=status.HTTP_404_NOT_FOUND,

tests/e2e/features/query.feature

@@ -168,9 +168,9 @@ Scenario: Check if LLM responds for query request with error for missing query
     }
     """
     Then The status code of the response is 200
-Scenario: Check if LLM responds with an error when no models are configured
-    Given The service is started locally
-    And REST API service prefix is /v1
+
+  @no_models
+  Scenario: Check if LLM responds with an error when no models are configured
     Given The system is in default state
     And I set the Authorization header to Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6Ikpva
     When I use "query" to ask question with authorization header

tests/e2e/features/streaming_query.feature

@@ -126,7 +126,7 @@ Feature: streaming_query endpoint API tests
      """
      {"query": "Say hello"}
      """
-      Then The status code of the response is 400
+      Then The status code of the response is 401
       And The body of the response is the following
           """
           {"detail": "No Authorization header found"}

tests/integration/test_openapi_json.py

@@ -129,7 +129,7 @@ def test_servers_section_present_from_url(spec_from_url: dict[str, Any]) -> None
         ("/v1/shields", "get", {"200", "500"}),
         ("/v1/providers", "get", {"200", "500"}),
         ("/v1/providers/{provider_id}", "get", {"200", "404", "422", "500"}),
-        ("/v1/query", "post", {"200", "400", "403", "500", "422"}),
+        ("/v1/query", "post", {"200", "401", "403", "404", "500", "422"}),
         ("/v1/streaming_query", "post", {"200", "400", "401", "403", "422", "500"}),
         ("/v1/config", "get", {"200", "503"}),
         ("/v1/feedback", "post", {"200", "401", "403", "500", "422"}),
@@ -185,7 +185,7 @@ def test_paths_and_responses_exist_from_file(
         ("/v1/shields", "get", {"200", "500"}),
         ("/v1/providers", "get", {"200", "500"}),
         ("/v1/providers/{provider_id}", "get", {"200", "404", "422", "500"}),
-        ("/v1/query", "post", {"200", "400", "403", "500", "422"}),
+        ("/v1/query", "post", {"200", "401", "403", "404", "500", "422"}),
         ("/v1/streaming_query", "post", {"200", "400", "401", "403", "422", "500"}),
         ("/v1/config", "get", {"200", "503"}),
         ("/v1/feedback", "post", {"200", "401", "403", "500", "422"}),

tests/unit/app/endpoints/test_query.py

@@ -459,7 +459,7 @@ def test_select_model_and_provider_id_no_available_models(
             mock_client.models.list(), query_request.model, query_request.provider
         )
 
-    assert "No LLM model found in available models" in str(exc_info.value)
+    assert "No models available" in str(exc_info.value)
 
 
 def test_validate_attachments_metadata() -> None: