Skip to content

[bug]: lncli listpayments --count_total_payments should not return a copy of all payments, instead it should return only the total #9742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZZiigguurraatt opened this issue Apr 20, 2025 · 0 comments
Labels
bug Unintended code behaviour needs triage

Comments

@ZZiigguurraatt
Copy link

Right now because of #8530 we can use

lncli listpayments --count_total_payments --max_payments 2|jq .total_num_payments

to count the total number of payments without receiving a copy of them all. However, once #8530 is fixed, we won't have a way to count the total with large databases because of #9709 .

I think we should change lncli listpayments --count_total_payments to not return a copy of all payments, instead it should return only the total.

What does everyone else think?

#9740 aims to fix #9717 and it is designed to only return the total, not a copy of the invoices too. I'm thinking that is the better approach and should work in the same way with listpayments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unintended code behaviour needs triage
Projects
None yet
Development

No branches or pull requests

1 participant