sphinx: remove unused members of Router #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By removing the unused members of the Router, we can remove the network parameter from NewRouter which will make it easier to instantiate the Router in other packages.
Collaborator
Author
|
cc @ziggie1984 & @bitromortac Tiny one that will make the 2nd Route blinding PR cleaner :) |
Collaborator
Author
|
thanks y'all! 🚀 cc @Roasbeef for merge 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing the unused members of the Router, we can remove the network parameter from NewRouter which will make it easier to instantiate the Router in other packages.
This will simplify the code for route blinding receives a bit simpler.