sphinx: remove unused nodeAddr #58
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostjager
force-pushed
the
remove-unused-node-addr
branch
from
eedc3a9 to
1fc86b1
Compare
Contributor
Author
|
Requesting review @Roasbeef |
Member
|
I think this is a sane change, but it does end up breaking the API for all callers. As an intermediate step, we could just remove the internal field? Or is there some other motivation behind this change? |
Contributor
Author
|
The goal is to break up the API for all callers, so that the caller code can be simplified as well. |
Collaborator
|
ah, this has now been addressed in #62, So i think we can close this now (I dont have perms to close) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.