itest: add test for full UTXO burns

Author: darioAnongba

itest/burn_test.go

@@ -8,7 +8,6 @@ import (
 	taprootassets "github.com/lightninglabs/taproot-assets"
 	"github.com/lightninglabs/taproot-assets/address"
 	"github.com/lightninglabs/taproot-assets/asset"
-	"github.com/lightninglabs/taproot-assets/tapfreighter"
 	"github.com/lightninglabs/taproot-assets/tappsbt"
 	"github.com/lightninglabs/taproot-assets/taprpc"
 	wrpc "github.com/lightninglabs/taproot-assets/taprpc/assetwalletrpc"
@@ -111,23 +110,7 @@ func testBurnAssets(t *harnessTest) {
 		t.t, t.tapd, simpleAssetGen.AssetId, simpleAsset.Amount,
 	)
 
-	// Test case 1: We'll now try to the exact amount of the largest output,
-	// which should still select exactly that one largest output, which is
-	// located alone in an anchor output. When attempting to burn this, we
-	// should get an error saying that we cannot completely burn all assets
-	// in an output.
-	_, err = t.tapd.BurnAsset(ctxt, &taprpc.BurnAssetRequest{
-		Asset: &taprpc.BurnAssetRequest_AssetId{
-			AssetId: simpleAssetID[:],
-		},
-		AmountToBurn:     outputAmounts[3],
-		ConfirmationText: taprootassets.AssetBurnConfirmationText,
-	})
-	require.ErrorContains(
-		t.t, err, tapfreighter.ErrFullBurnNotSupported.Error(),
-	)
-
-	// Test case 2: We'll now try to burn a small amount of assets, which
+	// Test case 1: We'll now try to burn a small amount of assets, which
 	// should select the largest output, which is located alone in an anchor
 	// output.
 	const (
@@ -208,7 +191,7 @@ func testBurnAssets(t *harnessTest) {
 	AssertNonInteractiveRecvComplete(t.t, t.tapd, 1)
 	AssertReceiveEvents(t.t, fullSendAddr, stream)
 
-	// Test case 3: Burn all assets of one asset ID (in this case a single
+	// Test case 2: Burn all assets of one asset ID (in this case a single
 	// collectible from the original mint TX), while there are other,
 	// passive assets in the anchor output.
 	burnResp, err = t.tapd.BurnAsset(ctxt, &taprpc.BurnAssetRequest{
@@ -237,7 +220,7 @@ func testBurnAssets(t *harnessTest) {
 		WithScriptKeyType(asset.ScriptKeyBurn),
 	)
 
-	// Test case 4: Burn assets from multiple inputs. This will select the
+	// Test case 3: Burn assets from multiple inputs. This will select the
 	// two largest inputs we have, the one over 1500 we sent above and the
 	// 1200 from the initial fan out transfer.
 	const changeAmt = 300
@@ -283,7 +266,7 @@ func testBurnAssets(t *harnessTest) {
 	require.NoError(t.t, err)
 	t.Logf("All assets before last burn: %v", assets)
 
-	// Test case 5: Burn some units of a grouped asset. We start by making
+	// Test case 4: Burn some units of a grouped asset. We start by making
 	// sure we still have the full balance before burning.
 	AssertBalanceByID(
 		t.t, t.tapd, simpleGroupGen.AssetId, simpleGroup.Amount,
@@ -344,7 +327,7 @@ func testBurnAssets(t *harnessTest) {
 
 	require.Equal(t.t, groupBurn.Note, "")
 
-	// Test case 6: Burn the single unit of a grouped collectible. We start
+	// Test case 5: Burn the single unit of a grouped collectible. We start
 	// by making sure we still have the full balance before burning.
 	AssertBalanceByID(
 		t.t, t.tapd, simpleGroupCollectGen.AssetId,
@@ -524,3 +507,83 @@ func testBurnGroupedAssets(t *harnessTest) {
 	require.Equal(t.t, burnNote, burn.Note)
 	require.Equal(t.t, assetGroupKey, burn.TweakedGroupKey)
 }
+
+// testFullBurnUTXO tests that we can burn the full amount of an asset UTXO
+func testFullBurnUTXO(t *harnessTest) {
+	minerClient := t.lndHarness.Miner().Client
+	ctxb := context.Background()
+	ctxt, cancel := context.WithTimeout(ctxb, defaultWaitTimeout)
+	defer cancel()
+
+	rpcAssets := MintAssetsConfirmBatch(
+		t.t, minerClient, t.tapd, []*mintrpc.MintAssetRequest{
+			simpleAssets[0],
+		},
+	)
+	simpleAsset := rpcAssets[0]
+	simpleAssetGen := simpleAsset.AssetGenesis
+
+	var simpleAssetID [32]byte
+	copy(simpleAssetID[:], simpleAssetGen.AssetId)
+
+	scriptKey1, anchorKeyDesc1 := DeriveKeys(t.t, t.tapd)
+	scriptKey2, anchorKeyDesc2 := DeriveKeys(t.t, t.tapd)
+	chainParams := &address.RegressionNetTap
+
+	// Create two outputs on different anchors.
+	outputAmounts := []uint64{simpleAsset.Amount - 4200, 1200, 3000}
+	vPkt := tappsbt.ForInteractiveSend(
+		simpleAssetID, outputAmounts[1], scriptKey1,
+		0, 0, 0, anchorKeyDesc1, asset.V0, chainParams,
+	)
+	tappsbt.AddOutput(
+		vPkt, outputAmounts[2], scriptKey2, 1, anchorKeyDesc2, asset.V0,
+	)
+
+	fundResp := fundPacket(t, t.tapd, vPkt)
+	signResp, err := t.tapd.SignVirtualPsbt(
+		ctxt, &wrpc.SignVirtualPsbtRequest{
+			FundedPsbt: fundResp.FundedPsbt,
+		},
+	)
+	require.NoError(t.t, err)
+	sendResp, err := t.tapd.AnchorVirtualPsbts(
+		ctxt, &wrpc.AnchorVirtualPsbtsRequest{
+			VirtualPsbts: [][]byte{signResp.SignedPsbt},
+		},
+	)
+	require.NoError(t.t, err)
+	ConfirmAndAssertOutboundTransferWithOutputs(
+		t.t, minerClient, t.tapd, sendResp, simpleAssetGen.AssetId,
+		outputAmounts, 0, 1, 3,
+	)
+
+	// Verify pre-burn balance.
+	AssertBalanceByID(
+		t.t, t.tapd, simpleAssetGen.AssetId, simpleAsset.Amount,
+	)
+
+	// Perform a full burn of the isolated largest output (1200).
+	fullBurnAmt := outputAmounts[2]
+	burnResp, err := t.tapd.BurnAsset(ctxt, &taprpc.BurnAssetRequest{
+		Asset: &taprpc.BurnAssetRequest_AssetId{
+			AssetId: simpleAssetID[:],
+		},
+		AmountToBurn:     fullBurnAmt,
+		ConfirmationText: taprootassets.AssetBurnConfirmationText,
+	})
+	require.NoError(t.t, err)
+
+	// Expect burn output and tombstone split root.
+	AssertAssetOutboundTransferWithOutputs(
+		t.t, minerClient, t.tapd, burnResp.BurnTransfer,
+		[][]byte{simpleAssetGen.AssetId},
+		[]uint64{fullBurnAmt, 0}, 1, 2, 2, true,
+	)
+
+	// Balance reflects the full burn amount.
+	AssertBalanceByID(
+		t.t, t.tapd, simpleAssetGen.AssetId,
+		simpleAsset.Amount-fullBurnAmt,
+	)
+}

itest/test_list_on_test.go

@@ -309,6 +309,10 @@ var allTestCases = []*testCase{
 		name: "burn grouped assets",
 		test: testBurnGroupedAssets,
 	},
+	{
+		name: "full burn assets",
+		test: testFullBurnUTXO,
+	},
 	{
 		name: "federation sync config",
 		test: testFederationSyncConfig,