Skip to content

Get rid of unnecessary ChannelMonitor in Channel #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
valentinewallace opened this issue Jul 17, 2020 · 0 comments · Fixed by #667
Closed

Get rid of unnecessary ChannelMonitor in Channel #657

valentinewallace opened this issue Jul 17, 2020 · 0 comments · Fixed by #667
Assignees
@valentinewallace

Comments

@valentinewallace
Copy link
Contributor

In preparation for refactoring how we persist channel data, we need to get rid of the Channel's ChannelMonitor. The only reason it exists now is because of the ChannelManager calling would_broadcast_at_height. would_broadcast_at_height provides information that should be accessible in a different way (that doesn't require the Channel to hold its ChannelMonitor).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinewallace valentinewallace

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Channel's ChannelMonitor copy valentinewallace/rust-lightning
1 participant
@valentinewallace