You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Everything other than a few sync state cases that are really hard to cover in the current object design is tested as part of my work on top of #494 (arik-so#3). Due to the large code moves, I felt it was a better starting point to unify all the work in progress.
The number of tests needed to exercise the various behaviors of the PeerManager point to a maintainability yellow flag. It is probably a good idea to revisit some of the behaviors and attempt to split them out into separate testable objects. I think my work is a good step towards having a better safety net for new features that need to be added, but there is still quite a bit of work there to make it maintainable long term.
The public methods of
PeerManager
are largely untested. This may need to wait for ongoing refactoring.The text was updated successfully, but these errors were encountered: