Skip to content

Rewrite unit tests for peer_handler module #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jkczyz opened this issue Mar 3, 2020 · 1 comment
Open

Rewrite unit tests for peer_handler module #528

jkczyz opened this issue Mar 3, 2020 · 1 comment
Labels
good first issue Good for newcomers

Comments

@jkczyz
Copy link
Contributor

jkczyz commented Mar 3, 2020

The public methods of PeerManager are largely untested. This may need to wait for ongoing refactoring.

@julianknutsen
Copy link

julianknutsen commented Sep 8, 2020

Everything other than a few sync state cases that are really hard to cover in the current object design is tested as part of my work on top of #494 (arik-so#3). Due to the large code moves, I felt it was a better starting point to unify all the work in progress.

The number of tests needed to exercise the various behaviors of the PeerManager point to a maintainability yellow flag. It is probably a good idea to revisit some of the behaviors and attempt to split them out into separate testable objects. I think my work is a good step towards having a better safety net for new features that need to be added, but there is still quite a bit of work there to make it maintainable long term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants