Skip to content

PaymentForwarded should include counterparty nodes #3455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheBlueMatt opened this issue Dec 11, 2024 · 1 comment · Fixed by #3458
Closed

PaymentForwarded should include counterparty nodes #3455

TheBlueMatt opened this issue Dec 11, 2024 · 1 comment · Fixed by #3458
Milestone

Comments

@TheBlueMatt
Copy link
Collaborator

It just includes ChannelIds, which is generally fine (if you're forwarding hopefully it's not over 0conf channels), but technically ChannelIds aren't unique (for v1 0conf opens) so we need to include the counterparty node ids. I mean also as should because they're, like, useful.

@TheBlueMatt TheBlueMatt added this to the 0.1 milestone Dec 11, 2024
@tnull
Copy link
Contributor

tnull commented Dec 11, 2024

When we do this it might make sense to keep it consitent with the channel ID and user channel ID fields, i.e., introduce next_node_id and prev_node_id fields, IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants