Skip to content

Expose advance_path_by_one #3134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheBlueMatt opened this issue Jun 19, 2024 · 6 comments · Fixed by #3182
Closed

Expose advance_path_by_one #3134

TheBlueMatt opened this issue Jun 19, 2024 · 6 comments · Fixed by #3182
Assignees
Milestone

Comments

@TheBlueMatt
Copy link
Collaborator

In #3132 we created advance_path_by_one to handle the case where are the intro node on a payment, but I believe LNDK may need that as well. We should check with them and then maybe expose it.

@TheBlueMatt TheBlueMatt added this to the 0.0.124 milestone Jun 19, 2024
@TheBlueMatt TheBlueMatt removed this from the 0.0.124 milestone Jul 11, 2024
@orbitalturtle
Copy link
Contributor

@TheBlueMatt Yes confirmed this would be helpful!

@TheBlueMatt TheBlueMatt added this to the 0.0.124 milestone Jul 11, 2024
@TheBlueMatt
Copy link
Collaborator Author

Then I'll leave the milestone on it, though its somewhat optimistic it'll make it.

@valentinewallace
Copy link
Contributor

@orbitalturtle Do you need to be able to advance blinded message paths as well, or just payment paths?

@orbitalturtle
Copy link
Contributor

@valentinewallace Ah yup we need it for messages as well

@valentinewallace
Copy link
Contributor

@valentinewallace Ah yup we need it for messages as well

Cool, added this to #3182.

@orbitalturtle
Copy link
Contributor

@valentinewallace Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants