Skip to content

Create RGS test utility for generating sample byte data #2030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
arik-so opened this issue Feb 13, 2023 · 3 comments
Open

Create RGS test utility for generating sample byte data #2030

arik-so opened this issue Feb 13, 2023 · 3 comments
Assignees
@arik-so

Comments

@arik-so
Copy link
Contributor

arik-so commented Feb 13, 2023

Currently, the byte data is pre-generated from a local server instance I had running with various customization flags. This is makes the unit tests inscrutable.
@arik-so arik-so self-assigned this Feb 13, 2023
@arik-so arik-so mentioned this issue Feb 13, 2023
Merged
@arik-so
Copy link
Contributor Author

arik-so commented Apr 4, 2023

Should this support the generation of invalid or malformed blobs? For example, blobs where an announcement or an update references an out-of-index node pubkey?

@benthecarman
Copy link
Contributor

This would be great for us @MutinyWallet, right now we have our test download the testnet RGS data to test against

@arik-so
Copy link
Contributor Author

arik-so commented Apr 5, 2023

All right, I'll think about how to make a good method signature for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arik-so arik-so

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arik-so @benthecarman