Skip to content

Make chain::Access async-optional #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheBlueMatt opened this issue Jan 20, 2023 · 1 comment · Fixed by #1980
Closed

Make chain::Access async-optional #1975

TheBlueMatt opened this issue Jan 20, 2023 · 1 comment · Fixed by #1980

Comments

@TheBlueMatt
Copy link
Collaborator

We'll need to be careful to ensure that any "downstream" messages (ie node_announcement/channel_update) to a pending channel_announcement are held and not processed until the async query resolves. Ideally we can do this without storing the pending messages in the network graph itself, maybe just storing a map from the pending SCIDs to a weak pointer to the future, adding pending to-process messages to the future object itself and making users call back into the graph with the future object.

@TheBlueMatt
Copy link
Collaborator Author

I needed this for a personal project, so I went ahead and did it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant